thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-26 17:41:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Blob Storage endpoint url verification using re2

Browse Source
This commit is contained in:
Jakub Kuklis 2021-10-08 15:26:58 +00:00
parent 63ec8d4244
commit b41ab197e8
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Disks/BlobStorage/registerDiskBlobStorage.cpp
View File

@ -10,6 +10,7 @@
#include <Disks/DiskRestartProxy.h> #include <Disks/DiskRestartProxy.h>
#include <Disks/DiskCacheWrapper.h> #include <Disks/DiskCacheWrapper.h>
#include <azure/identity/managed_identity_credential.hpp> #include <azure/identity/managed_identity_credential.hpp>
#include <re2/re2.h>
namespace DB namespace DB
@ -53,12 +54,25 @@ void checkReadAccess(IDisk & disk)
} }
void checkRemoveAccess(IDisk & disk) { void checkRemoveAccess(IDisk & disk)
{
// TODO: implement actually removing the file from Blob Storage cloud, now it seems only the metadata file is removed // TODO: implement actually removing the file from Blob Storage cloud, now it seems only the metadata file is removed
disk.removeFile(test_file); disk.removeFile(test_file);
} }
void validate_endpoint_url(const String & endpoint_url)
{
auto endpoint_url_pattern_str = "http(()|s)://[a-z0-9-]+\\.blob\\.core\\.windows\\.net/[a-z0-9-]+";
static const RE2 endpoint_url_pattern(endpoint_url_pattern_str);
if (!re2::RE2::FullMatch(endpoint_url, endpoint_url_pattern))
{
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Blob Storage URL is not valid, should follow the format: {}, got: {}", endpoint_url_pattern_str, endpoint_url);
}
}
std::unique_ptr<DiskBlobStorageSettings> getSettings(const Poco::Util::AbstractConfiguration & config, const String & config_prefix, ContextPtr /* context */) std::unique_ptr<DiskBlobStorageSettings> getSettings(const Poco::Util::AbstractConfiguration & config, const String & config_prefix, ContextPtr /* context */)
{ {
return std::make_unique<DiskBlobStorageSettings>( return std::make_unique<DiskBlobStorageSettings>(
@ -83,6 +97,8 @@ void registerDiskBlobStorage(DiskFactory & factory)
const DisksMap &) const DisksMap &)
{ {
auto endpoint_url = config.getString(config_prefix + ".endpoint", "https://sadttmpstgeus.blob.core.windows.net/data"); // TODO: remove default url auto endpoint_url = config.getString(config_prefix + ".endpoint", "https://sadttmpstgeus.blob.core.windows.net/data"); // TODO: remove default url
validate_endpoint_url(endpoint_url);
auto managed_identity_credential = std::make_shared<Azure::Identity::ManagedIdentityCredential>(); auto managed_identity_credential = std::make_shared<Azure::Identity::ManagedIdentityCredential>();
auto blob_container_client = Azure::Storage::Blobs::BlobContainerClient(endpoint_url, managed_identity_credential); auto blob_container_client = Azure::Storage::Blobs::BlobContainerClient(endpoint_url, managed_identity_credential);