thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ReturnType template parameter to FormatImpl::execute

Browse Source
This commit is contained in:
vdimir 2021-07-12 16:02:15 +03:00
parent 32b174403e
commit b4c6a17eb2
No known key found for this signature in database
GPG Key ID: F57B3E10A21DBB31
1 changed files with 42 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
src/Functions/FunctionsConversion.h
View File

@ -576,77 +576,82 @@ template <typename Name> struct ConvertImpl<DataTypeDateTime, DataTypeDateTime64
/** Transformation of numbers, dates, datetimes to strings: through formatting. /** Transformation of numbers, dates, datetimes to strings: through formatting.
*/ */
template <typename DataType, bool throws> template <typename DataType>
struct FormatImpl struct FormatImpl
{ {
static bool execute(const typename DataType::FieldType x, WriteBuffer & wb, const DataType *, const DateLUTImpl *) template <typename ReturnType = void>
static ReturnType execute(const typename DataType::FieldType x, WriteBuffer & wb, const DataType *, const DateLUTImpl *)
{ {
writeText(x, wb); writeText(x, wb);
return true; return ReturnType(true);
} }
}; };
template <bool throws> template <>
struct FormatImpl<DataTypeDate, throws> struct FormatImpl<DataTypeDate>
{ {
static bool execute(const DataTypeDate::FieldType x, WriteBuffer & wb, const DataTypeDate *, const DateLUTImpl *) template <typename ReturnType = void>
static ReturnType execute(const DataTypeDate::FieldType x, WriteBuffer & wb, const DataTypeDate *, const DateLUTImpl *)
{ {
writeDateText(DayNum(x), wb); writeDateText(DayNum(x), wb);
return true; return ReturnType(true);
} }
}; };
template <bool throws> template <>
struct FormatImpl<DataTypeDateTime, throws> struct FormatImpl<DataTypeDateTime>
{ {
static bool execute(const DataTypeDateTime::FieldType x, WriteBuffer & wb, const DataTypeDateTime *, const DateLUTImpl * time_zone) template <typename ReturnType = void>
static ReturnType execute(const DataTypeDateTime::FieldType x, WriteBuffer & wb, const DataTypeDateTime *, const DateLUTImpl * time_zone)
{ {
writeDateTimeText(x, wb, *time_zone); writeDateTimeText(x, wb, *time_zone);
return true; return ReturnType(true);
} }
}; };
template <bool throws> template <>
struct FormatImpl<DataTypeDateTime64, throws> struct FormatImpl<DataTypeDateTime64>
{ {
static bool execute(const DataTypeDateTime64::FieldType x, WriteBuffer & wb, const DataTypeDateTime64 * type, const DateLUTImpl * time_zone) template <typename ReturnType = void>
static ReturnType execute(const DataTypeDateTime64::FieldType x, WriteBuffer & wb, const DataTypeDateTime64 * type, const DateLUTImpl * time_zone)
{ {
writeDateTimeText(DateTime64(x), type->getScale(), wb, *time_zone); writeDateTimeText(DateTime64(x), type->getScale(), wb, *time_zone);
return true; return ReturnType(true);
} }
}; };
template <typename FieldType> template <typename FieldType>
struct FormatImpl<DataTypeEnum<FieldType>, false> struct FormatImpl<DataTypeEnum<FieldType>>
{ {
static bool execute(const FieldType x, WriteBuffer & wb, const DataTypeEnum<FieldType> * type, const DateLUTImpl *) template <typename ReturnType = void>
static ReturnType execute(const FieldType x, WriteBuffer & wb, const DataTypeEnum<FieldType> * type, const DateLUTImpl *)
{ {
StringRef res; static constexpr bool throw_exception = std::is_same_v<ReturnType, void>;
bool is_ok = type->getNameForValue(x, res);
if (is_ok) if constexpr (throw_exception)
writeString(res, wb); {
return is_ok; writeString(type->getNameForValue(x), wb);
}
else
{
StringRef res;
bool is_ok = type->getNameForValue(x, res);
if (is_ok)
writeString(res, wb);
return ReturnType(is_ok);
}
} }
}; };
template <typename FieldType> template <typename FieldType>
struct FormatImpl<DataTypeEnum<FieldType>, true> struct FormatImpl<DataTypeDecimal<FieldType>>
{ {
static bool execute(const FieldType x, WriteBuffer & wb, const DataTypeEnum<FieldType> * type, const DateLUTImpl *) template <typename ReturnType = void>
{ static ReturnType execute(const FieldType x, WriteBuffer & wb, const DataTypeDecimal<FieldType> * type, const DateLUTImpl *)
writeString(type->getNameForValue(x), wb);
return true;
}
};
template <typename FieldType, bool throws>
struct FormatImpl<DataTypeDecimal<FieldType>, throws>
{
static bool execute(const FieldType x, WriteBuffer & wb, const DataTypeDecimal<FieldType> * type, const DateLUTImpl *)
{ {
writeText(x, type->getScale(), wb); writeText(x, type->getScale(), wb);
return true; return ReturnType(true);
} }
}; };
@ -716,12 +721,12 @@ struct ConvertImpl<FromDataType, std::enable_if_t<!std::is_same_v<FromDataType,
{ {
if (null_map) if (null_map)
{ {
bool is_ok = FormatImpl<FromDataType, false>::execute(vec_from[i], write_buffer, &type, time_zone); bool is_ok = FormatImpl<FromDataType>::template execute<bool>(vec_from[i], write_buffer, &type, time_zone);
null_map->getData()[i] |= !is_ok; null_map->getData()[i] |= !is_ok;
} }
else else
{ {
FormatImpl<FromDataType, true>::execute(vec_from[i], write_buffer, &type, time_zone); FormatImpl<FromDataType>::template execute<void>(vec_from[i], write_buffer, &type, time_zone);
} }
writeChar(0, write_buffer); writeChar(0, write_buffer);
offsets_to[i] = write_buffer.count(); offsets_to[i] = write_buffer.count();