diff --git a/src/Disks/FakeDiskTransaction.h b/src/Disks/FakeDiskTransaction.h index 7f9247a0689..fae43ae3d2a 100644 --- a/src/Disks/FakeDiskTransaction.h +++ b/src/Disks/FakeDiskTransaction.h @@ -17,7 +17,6 @@ public: void commit() override { - commit_called = true; } void createDirectory(const std::string & path) override @@ -125,14 +124,8 @@ public: disk.createHardLink(src_path, dst_path); } - bool isCommitedOrTriedToCommit() const override - { - return commit_called; - } - private: IDisk & disk; - bool commit_called{false}; }; } diff --git a/src/Disks/IDiskTransaction.h b/src/Disks/IDiskTransaction.h index e51a02267d1..4b00a9bcefc 100644 --- a/src/Disks/IDiskTransaction.h +++ b/src/Disks/IDiskTransaction.h @@ -108,8 +108,6 @@ public: /// Create hardlink from `src_path` to `dst_path`. virtual void createHardLink(const std::string & src_path, const std::string & dst_path) = 0; - - virtual bool isCommitedOrTriedToCommit() const = 0; }; using DiskTransactionPtr = std::shared_ptr; diff --git a/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp b/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp index e07b050dd1f..224174ee5a9 100644 --- a/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp +++ b/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp @@ -602,7 +602,6 @@ void DiskObjectStorageTransaction::copyFile(const std::string & from_file_path, void DiskObjectStorageTransaction::commit() { - commit_called = true; for (size_t i = 0; i < operations_to_execute.size(); ++i) { try diff --git a/src/Disks/ObjectStorages/DiskObjectStorageTransaction.h b/src/Disks/ObjectStorages/DiskObjectStorageTransaction.h index 6ce0d2bcdd2..362b5404707 100644 --- a/src/Disks/ObjectStorages/DiskObjectStorageTransaction.h +++ b/src/Disks/ObjectStorages/DiskObjectStorageTransaction.h @@ -58,7 +58,6 @@ private: DiskObjectStorageRemoteMetadataRestoreHelper * metadata_helper; DiskObjectStorageOperations operations_to_execute; - bool commit_called{false}; public: DiskObjectStorageTransaction( IObjectStorage & object_storage_, @@ -108,11 +107,6 @@ public: void setLastModified(const std::string & path, const Poco::Timestamp & timestamp) override; void setReadOnly(const std::string & path) override; void createHardLink(const std::string & src_path, const std::string & dst_path) override; - - bool isCommitedOrTriedToCommit() const override - { - return commit_called; - } }; using DiskObjectStorageTransactionPtr = std::shared_ptr;