thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix intDiv of const divider

Browse Source
This commit is contained in:
hcz 2020-02-25 12:58:26 +08:00
parent 1803656b9f
commit ba35ba01cf
3 changed files with 73 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dbms/src/Functions/intDiv.cpp
View File

@ -33,7 +33,7 @@ struct DivideIntegralByConstantImpl
{ {
size_t size = a.size(); size_t size = a.size();
for (size_t i = 0; i < size; ++i) for (size_t i = 0; i < size; ++i)
c[i] = -c[i]; c[i] = -a[i];
return; return;
} }

60
dbms/tests/queries/0_stateless/00977_int_div.reference
View File

@ -21,3 +21,63 @@
0 0
0 0
0 0
-1
-2
-3
-4
-5
-6
-7
-8
-9
-10
-1
-2
-3
-4
-5
-6
-7
-8
-9
-10
-1
-2
-3
-4
-5
-6
-7
-8
-9
-10
-1
-2
-3
-4
-5
-6
-7
-8
-9
-10
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1
-1

18
dbms/tests/queries/0_stateless/00977_int_div.sql
View File

@ -1,14 +1,14 @@
SELECT SELECT
sum(ASD) AS asd, sum(ASD) AS asd,
intDiv(toInt64(asd), abs(toInt64(asd))) AS int_div_with_abs, intDiv(toInt64(asd), abs(toInt64(asd))) AS int_div_with_abs,
intDiv(toInt64(asd), toInt64(asd)) AS int_div_without_abs intDiv(toInt64(asd), toInt64(asd)) AS int_div_without_abs
FROM FROM
( (
SELECT ASD SELECT ASD
FROM FROM
( (
SELECT [-1000, -1000] AS asds SELECT [-1000, -1000] AS asds
) )
ARRAY JOIN asds AS ASD ARRAY JOIN asds AS ASD
); );
@ -17,3 +17,9 @@ SELECT intDivOrZero( CAST(-1000, 'Int64') , CAST(1000, 'Int64') );
SELECT intDiv(-1, number) FROM numbers(1, 10); SELECT intDiv(-1, number) FROM numbers(1, 10);
SELECT intDivOrZero(-1, number) FROM numbers(1, 10); SELECT intDivOrZero(-1, number) FROM numbers(1, 10);
SELECT intDiv(toInt32(number), -1) FROM numbers(1, 10);
SELECT intDivOrZero(toInt32(number), -1) FROM numbers(1, 10);
SELECT intDiv(toInt64(number), -1) FROM numbers(1, 10);
SELECT intDivOrZero(toInt64(number), -1) FROM numbers(1, 10);
SELECT intDiv(number, -number) FROM numbers(1, 10);
SELECT intDivOrZero(number, -number) FROM numbers(1, 10);