thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent overflow error in utc timestamp conversion

Browse Source
This commit is contained in:
arunppsg 2024-11-15 16:11:29 +05:30
parent bdd18b35b2
commit bb10f5c27e
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Functions/UTCTimestampTransform.cpp
View File

@ -88,10 +88,20 @@ namespace
{ {
UInt32 date_time_val = date_time_col.getElement(i); UInt32 date_time_val = date_time_col.getElement(i);
auto time_zone_offset = time_zone.timezoneOffset(date_time_val); auto time_zone_offset = time_zone.timezoneOffset(date_time_val);
if constexpr (toUTC) if constexpr (toUTC) {
result_data[i] = date_time_val - static_cast<UInt32>(time_zone_offset); result_data[i] = date_time_val - static_cast<UInt32>(time_zone_offset);
else if (result_data[i] > date_time_val) {
// Overflow occured
result_data[i] = UINT32_MAX;
}
}
else {
result_data[i] = date_time_val + static_cast<UInt32>(time_zone_offset); result_data[i] = date_time_val + static_cast<UInt32>(time_zone_offset);
if (result_data[i] < date_time_val) {
// Underflow occurred
result_data[i] = 0;
}
}
} }
return result_column; return result_column;
} }