From bb17f14d837f0aabf47aafbcd6161f9d09c06e49 Mon Sep 17 00:00:00 2001
From: Alexander Kuzmenkov <akuzm@yandex-team.ru>
Date: Wed, 17 Mar 2021 18:55:53 +0300
Subject: [PATCH] fix

---
 programs/client/Client.cpp | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/programs/client/Client.cpp b/programs/client/Client.cpp
index 4a61662c238..4ba96280939 100644
--- a/programs/client/Client.cpp
+++ b/programs/client/Client.cpp
@@ -65,6 +65,7 @@
 #include <Parsers/ASTSetQuery.h>
 #include <Parsers/ASTUseQuery.h>
 #include <Parsers/ASTInsertQuery.h>
+#include <Parsers/ASTSelectQuery.h>
 #include <Parsers/ASTSelectWithUnionQuery.h>
 #include <Parsers/ASTQueryWithOutput.h>
 #include <Parsers/ASTLiteral.h>
@@ -116,6 +117,31 @@ namespace ErrorCodes
 }
 
 
+static bool queryHasWithClause(const IAST * ast)
+{
+    if (const auto * select = dynamic_cast<const ASTSelectQuery *>(ast);
+        select && select->with())
+    {
+        return true;
+    }
+
+    // This is a bit too much, because most of the children are not queries,
+    // but on the other hand it will let us to avoid breakage when the AST
+    // structure changes and some new variant of query nesting is added. This
+    // function is used in fuzzer, so it's better to be defensive and avoid
+    // weird unexpected errors.
+    for (const auto & child : ast->children)
+    {
+        if (queryHasWithClause(child.get()))
+        {
+            return true;
+        }
+    }
+
+    return false;
+}
+
+
 class Client : public Poco::Util::Application
 {
 public:
@@ -1429,7 +1455,11 @@ private:
             // when `lambda()` function gets substituted into a wrong place.
             // To avoid dealing with these cases, run the check only for the
             // queries we were able to successfully execute.
-            if (!have_error)
+            // The final caveat is that sometimes WITH queries are not executed,
+            // if they are not referenced by the main SELECT, so they can still
+            // have the abovementioned problems. Disable this check for such
+            // queries, for lack of a better solution.
+            if (!have_error && queryHasWithClause(parsed_query.get()))
             {
                 ASTPtr parsed_formatted_query;
                 try