Apply suggestions from code review

Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
This commit is contained in:
shuchaome 2022-03-09 17:32:27 +08:00 committed by GitHub
parent 9647818adc
commit bb50133424
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -529,7 +529,7 @@ void ArrowColumnToCHColumn::arrowTableToCHChunk(Chunk & res, std::shared_ptr<arr
throw Exception(ErrorCodes::DUPLICATE_COLUMN, "Column '{}' is duplicated", column_name);
if (enable_lowering_column_name)
boost::to_lower(column_name);
name_to_column_ptr[column_name] = arrow_column;
name_to_column_ptr[std::move(column_name)] = arrow_column;
}
arrowColumnsToCHChunk(res, name_to_column_ptr);

View File

@ -152,7 +152,7 @@ void ORCBlockInputFormat::prepareReader()
if (getPort().getHeader().has(name) || nested_table_names.contains(name))
{
column_names.push_back(name);
column_names.push_back(std::move(name));
for (int j = 0; j != indexes_count; ++j)
include_indices.push_back(index + j);
}