thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-15 12:14:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improvements based on review

Browse Source
This commit is contained in:
Raúl Marín 2024-10-30 13:23:48 +01:00
parent e2459c663d
commit bbbb81f43d
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/BaseSettings.cpp
View File

@ -41,7 +41,7 @@ UInt64 BaseSettingsHelpers::readFlags(ReadBuffer & in)
SettingsTierType BaseSettingsHelpers::getTier(UInt64 flags)
{
int8_t tier = (flags & Flags::TIER);
int8_t tier = static_cast<int8_t>(flags & Flags::TIER);
if (tier > SettingsTierType::BETA)
throw Exception(ErrorCodes::INCORRECT_DATA, "Unknown tier value: '{}'", tier);
return SettingsTierType{tier};

6
src/Core/Settings.cpp
View File

@ -38,7 +38,9 @@ namespace ErrorCodes
* Note: as an alternative, we could implement settings to be completely dynamic in the form of the map: String -> Field,
* but we are not going to do it, because settings are used everywhere as static struct fields.
*
* `flags` can be either 0 or IMPORTANT + a Tier (PRODUCTION | BETA | EXPERIMENTAL)
* `flags` can include a Tier (BETA | EXPERIMENTAL) and an optional bitwise AND with IMPORTANT.
* The default (0) means a PRODUCTION ready setting
*
* A setting is "IMPORTANT" if it affects the results of queries and can't be ignored by older versions.
* Tiers:
* EXPERIMENTAL: The feature is in active development stage. Mostly for developers or for ClickHouse enthusiasts.
@ -5824,8 +5826,6 @@ Experimental data deduplication for SELECT queries based on part UUIDs
\
/* ####################################################### */ \
/* ############ END OF EXPERIMENTAL FEATURES ############# */ \
/* ## ADD PRODUCTION / BETA FEATURES BEFORE THIS BLOCK ## */ \
/* ####################################################### */ \
/* ####################################################### */ \
// End of COMMON_SETTINGS