thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-21 17:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

dbms: Fixed error message. [#METR-19416]

Browse Source
This commit is contained in:
Alexey Arno 2016-03-10 17:58:31 +03:00
parent d5d334d5b8
commit bcd48f47e4
1 changed files with 8 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
dbms/include/DB/Functions/FunctionsDateTime.h
View File

@ -593,30 +593,15 @@ public:
}
else if (arguments.size() == 2)
{
std::string error_msg;
if (typeid_cast<const DataTypeDate *>(&*arguments[0]) != nullptr)
error_msg += "Illegal type " + arguments[0]->getName() + " of argument 1."
" Should be a date with time (timezones are not supported for dates)";
else if (typeid_cast<const DataTypeDateTime *>(&*arguments[0]) != nullptr)
{
/// Ничего не делаем.
}
else
error_msg += "Illegal type " + arguments[0]->getName() + " of argument 1."
" Should be a date with time";
if (typeid_cast<const DataTypeString *>(&*arguments[1]) == nullptr)
{
if (!error_msg.empty())
error_msg += ". ";
error_msg += "Illegal type " + arguments[1]->getName() + " of argument 2."
" Should be a string describing a timezone";
}
if (!error_msg.empty())
if ((typeid_cast<const DataTypeDate *>(&*arguments[0]) != nullptr)
|| (typeid_cast<const DataTypeDateTime *>(&*arguments[0]) == nullptr)
|| (typeid_cast<const DataTypeString *>(&*arguments[1]) == nullptr))
throw Exception{
"In function " + getName() + ": " + error_msg, ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT
"Function " + getName() + " supports 1 or 2 arguments. The 1st argument "
"must be of type Date or DateTime. The 2nd argument (optional) must be "
"a constant string with timezone name. The timezone argument is allowed "
"only when the 1st argument has the type DateTime",
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT
};
}
else