From bd0bc8e3e7c8f25cb7fbc5dd647d9a92162c4b78 Mon Sep 17 00:00:00 2001 From: kssenii Date: Fri, 21 May 2021 12:01:08 +0000 Subject: [PATCH] Revert "Adjust minMax index" This reverts commit c69f587f8a10a66aea1c366b9723cfbd463b7c6c. --- src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp | 10 ++++------ src/Storages/MergeTree/MergeTreeDataSelectExecutor.h | 3 +-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp b/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp index 7e61470c0ec..5f51358a7d2 100644 --- a/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp +++ b/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp @@ -497,7 +497,7 @@ QueryPlanPtr MergeTreeDataSelectExecutor::readFromParts( DataTypes minmax_columns_types; if (metadata_snapshot_base->hasPartitionKey()) { - const auto & partition_key = MergeTreePartition::adjustPartitionKey(metadata_snapshot_base, context); + const auto & partition_key = metadata_snapshot_base->getPartitionKey(); auto minmax_columns_names = data.getMinMaxColumnsNames(partition_key); minmax_columns_types = data.getMinMaxColumnsTypes(partition_key); @@ -1175,8 +1175,7 @@ QueryPlanPtr MergeTreeDataSelectExecutor::readFromParts( settings, reader_settings, result_projection, - query_id, - context); + query_id); } else if ((settings.optimize_read_in_order || settings.optimize_aggregation_in_order) && input_order_info) { @@ -1677,8 +1676,7 @@ QueryPlanPtr MergeTreeDataSelectExecutor::spreadMarkRangesAmongStreamsFinal( const Settings & settings, const MergeTreeReaderSettings & reader_settings, ActionsDAGPtr & out_projection, - const String & query_id, - ContextPtr context) const + const String & query_id) const { const auto data_settings = data.getSettings(); size_t sum_marks = 0; @@ -1828,7 +1826,7 @@ QueryPlanPtr MergeTreeDataSelectExecutor::spreadMarkRangesAmongStreamsFinal( size_t sort_columns_size = sort_columns.size(); sort_description.reserve(sort_columns_size); - Names partition_key_columns = MergeTreePartition::adjustPartitionKey(metadata_snapshot, context).column_names; + Names partition_key_columns = metadata_snapshot->getPartitionKey().column_names; const auto & header = plan->getCurrentDataStream().header; for (size_t i = 0; i < sort_columns_size; ++i) diff --git a/src/Storages/MergeTree/MergeTreeDataSelectExecutor.h b/src/Storages/MergeTree/MergeTreeDataSelectExecutor.h index cda8026a78d..8335e54213f 100644 --- a/src/Storages/MergeTree/MergeTreeDataSelectExecutor.h +++ b/src/Storages/MergeTree/MergeTreeDataSelectExecutor.h @@ -114,8 +114,7 @@ private: const Settings & settings, const MergeTreeReaderSettings & reader_settings, ActionsDAGPtr & out_projection, - const String & query_id, - ContextPtr context) const; + const String & query_id) const; /// Get the approximate value (bottom estimate - only by full marks) of the number of rows falling under the index. size_t getApproximateTotalRowsToRead(