thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-18 13:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

dbms: Server: Adding nullable type support to functions manipulating arrays. [#METR-19266]

Browse Source
This commit is contained in:
Alexey Arno 2016-09-21 11:24:48 +03:00
parent bad88a8062
commit bd53eb8054
1 changed files with 2 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
dbms/src/Functions/FunctionsArray.cpp
View File

@ -2538,27 +2538,6 @@ bool FunctionArrayReverse::executeFixedString(
{ {
if (const ColumnFixedString * src_data_concrete = typeid_cast<const ColumnFixedString *>(&src_data)) if (const ColumnFixedString * src_data_concrete = typeid_cast<const ColumnFixedString *>(&src_data))
{ {
/// XXX The original implementation, i.e. everything but the new code
/// XXX for nullable support is buggy. Example with a table with one column
/// XXX whose type is Array(FixedString(3))):
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
/// │ ['a\0\0','bc\0','def'] │
///
/// XXX SELECT reverse(col) FROM table gives the following output:
///
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','a\0\0','bc\0'] │
/// │ ['def','\0\0\0','\0\0\0'] │
const size_t n = src_data_concrete->getN(); const size_t n = src_data_concrete->getN();
const ColumnFixedString::Chars_t & src_data = src_data_concrete->getChars(); const ColumnFixedString::Chars_t & src_data = src_data_concrete->getChars();
ColumnFixedString::Chars_t & res_data = typeid_cast<ColumnFixedString &>(res_data_col).getChars(); ColumnFixedString::Chars_t & res_data = typeid_cast<ColumnFixedString &>(res_data_col).getChars();
@ -2579,7 +2558,8 @@ bool FunctionArrayReverse::executeFixedString(
while (src < src_end) while (src < src_end)
{ {
memcpySmallAllowReadWriteOverflow15(dst, src, n); /// NOTE: memcpySmallAllowReadWriteOverflow15 doesn't work correctly here.
memcpy(dst, src, n);
src += n; src += n;
dst -= n; dst -= n;
} }