thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Integration tests: fix flaky test_dictionaries_update_and_reload::test_reload_after_fail_by_timer

Browse Source
This commit is contained in:
Nikita Fomichev 2024-08-05 11:45:49 +02:00
parent 29f1d9df36
commit bd6c7a504d
1 changed files with 3 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/integration/test_dictionaries_update_and_reload/test.py
View File

@ -37,16 +37,6 @@ def get_status(dictionary_name):
).rstrip("\n")
def get_status_retry(dictionary_name, expect, retry_count=50, sleep_time=0.5):
for _ in range(retry_count):
res = get_status(dictionary_name)
if res == expect:
return res
time.sleep(sleep_time)
raise Exception(f'Expected result "{expect}" did not occur')
def get_last_exception(dictionary_name):
return (
instance.query(
@ -263,13 +253,7 @@ def test_reload_after_fail_by_timer(started_cluster):
# on sanitizers builds it can return 'FAILED_AND_RELOADING' which is not quite right
# add retry for these builds
if (
instance.is_built_with_sanitizer()
and get_status("no_file_2") == "FAILED_AND_RELOADING"
):
get_status_retry("no_file_2", expect="FAILED")
assert get_status("no_file_2") == "FAILED"
assert get_status("no_file_2") in ["FAILED", "FAILED_AND_RELOADING"]
# Creating the file source makes the dictionary able to load.
instance.copy_file_to_container(
@ -284,12 +268,7 @@ def test_reload_after_fail_by_timer(started_cluster):
)
instance.query("SYSTEM RELOAD DICTIONARY no_file_2")
instance.query("SELECT dictGetInt32('no_file_2', 'a', toUInt64(9))") == "10\n"
if (
instance.is_built_with_sanitizer()
and get_status("no_file_2") == "LOADED_AND_RELOADING"
):
get_status_retry("no_file_2", expect="LOADED")
assert get_status("no_file_2") == "LOADED"
assert get_status("no_file_2") in ["LOADED", "LOADED_AND_RELOADING"]
# Removing the file source should not spoil the loaded dictionary.
instance.exec_in_container(
@ -297,12 +276,7 @@ def test_reload_after_fail_by_timer(started_cluster):
)
time.sleep(6)
instance.query("SELECT dictGetInt32('no_file_2', 'a', toUInt64(9))") == "10\n"
if (
instance.is_built_with_sanitizer()
and get_status("no_file_2") == "LOADED_AND_RELOADING"
):
get_status_retry("no_file_2", expect="LOADED")
assert get_status("no_file_2") == "LOADED"
assert get_status("no_file_2") in ["LOADED", "LOADED_AND_RELOADING"]
def test_reload_after_fail_in_cache_dictionary(started_cluster):