thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix IN with nested tuples [#CLICKHOUSE-1999]

Browse Source
This commit is contained in:
artpaul 2017-03-01 19:48:21 +05:00
parent e7ee6dfd92
commit be7c70da5c
3 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dbms/src/Interpreters/Set.cpp
View File

@ -100,12 +100,18 @@ bool Set::insertFromBlock(const Block & block, bool create_ordered_set)
materialized_columns.emplace_back(converted); materialized_columns.emplace_back(converted);
key_columns.back() = materialized_columns.back().get(); key_columns.back() = materialized_columns.back().get();
} }
}
/** Flatten tuples. For case when written /** Flatten tuples. For case when written
* (a, b) IN (SELECT (a, b) FROM table) * (a, b) IN (SELECT (a, b) FROM table)
* instead of more typical * instead of more typical
* (a, b) IN (SELECT a, b FROM table) * (a, b) IN (SELECT a, b FROM table)
*
* Avoid flatten in case then we have more than one column:
* Ex.: 1, (2, 3) become just 1, 2, 3
*/ */
if (keys_size == 1)
{
if (const ColumnTuple * tuple = typeid_cast<const ColumnTuple *>(key_columns.back())) if (const ColumnTuple * tuple = typeid_cast<const ColumnTuple *>(key_columns.back()))
{ {
key_columns.pop_back(); key_columns.pop_back();
@ -229,7 +235,7 @@ void Set::createFromAST(const DataTypes & types, ASTPtr node, const Context & co
if (value.isNull()) if (value.isNull())
break; break;
tuple_values[j] = value; /// TODO Сделать move семантику для Field. tuple_values[j] = value;
} }
if (j == tuple_size) if (j == tuple_size)

5
dbms/tests/queries/0_stateless/00132_sets.reference
View File

@ -25,3 +25,8 @@
1 1
0 0
1 1
1 (2,3)
2 (2,3)
3 (2,3)
4 (2,3)
5 (2,3)

5
dbms/tests/queries/0_stateless/00132_sets.sql
View File

@ -19,3 +19,8 @@ SELECT ['Hello', 'world'] IN ('world');
SELECT ['Hello', 'world'] NOT IN ('world'); SELECT ['Hello', 'world'] NOT IN ('world');
SELECT ['Hello', 'world'] NOT IN ('Hello', 'world'); SELECT ['Hello', 'world'] NOT IN ('Hello', 'world');
SELECT ['Hello', 'world'] NOT IN ('hello', 'world'); SELECT ['Hello', 'world'] NOT IN ('hello', 'world');
SELECT number, tuple FROM (SELECT 1 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN (((1, (2, 3)), (4, (5, 6))));
SELECT number, tuple FROM (SELECT 2 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN ((2, (2, 3)));
SELECT number, tuple FROM (SELECT 3 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN (3, (2, 3));
SELECT number, tuple FROM (SELECT 4 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN (SELECT (4, (2, 3)));
SELECT number, tuple FROM (SELECT 5 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN (SELECT 5, (2, 3));