thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed assert in debug build

Browse Source
This commit is contained in:
Alexey Milovidov 2020-01-03 00:23:10 +03:00
parent 03be29eddb
commit c007c9fc17
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dbms/src/Functions/randomPrintableASCII.cpp
View File

@ -74,6 +74,7 @@ public:
data_to.resize(next_offset);
offsets_to[row_num] = next_offset;
auto * data_to_ptr = data_to.data(); /// avoid assert on array indexing after end
for (size_t pos = offset, end = offset + length; pos < end; pos += 4) /// We have padding in column buffers that we can overwrite.
{
UInt64 rand = thread_local_rng();
@ -86,10 +87,10 @@ public:
/// Printable characters are from range [32; 126].
/// https://lemire.me/blog/2016/06/27/a-fast-alternative-to-the-modulo-reduction/
data_to[pos + 0] = 32 + ((rand1 * 95) >> 16);
data_to[pos + 1] = 32 + ((rand2 * 95) >> 16);
data_to[pos + 2] = 32 + ((rand3 * 95) >> 16);
data_to[pos + 3] = 32 + ((rand4 * 95) >> 16);
data_to_ptr[pos + 0] = 32 + ((rand1 * 95) >> 16);
data_to_ptr[pos + 1] = 32 + ((rand2 * 95) >> 16);
data_to_ptr[pos + 2] = 32 + ((rand3 * 95) >> 16);
data_to_ptr[pos + 3] = 32 + ((rand4 * 95) >> 16);
/// NOTE gcc failed to vectorize this code (aliasing of char?)
/// TODO Implement SIMD optimizations from Danila Kutenin.