Merge pull request #41363 from kitaisreal/small-style-fixes

Small style fixes
This commit is contained in:
Alexey Milovidov 2022-09-17 00:19:00 +03:00 committed by GitHub
commit c09604bef2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 6 deletions

View File

@ -1665,7 +1665,7 @@ void AsynchronousMetrics::updateHeavyMetricsIfNeeded(TimePoint current_time, Tim
LOG_IMPL(log, log_level.first, log_level.second,
"Update heavy metrics. "
"Update period {} sec. "
"Update heavy metrics period {} sec. "
"Update heavy metrics period {} sec. "
"Heavy metrics calculation elapsed: {} sec.",
update_period.count(),
heavy_metric_update_period.count(),

View File

@ -28,16 +28,18 @@ namespace ErrorCodes
extern const int BAD_ARGUMENTS;
}
namespace
{
class UserDefinedFunction final : public IFunction
{
public:
explicit UserDefinedFunction(
ExternalUserDefinedExecutableFunctionsLoader::UserDefinedExecutableFunctionPtr executable_function_,
ContextPtr context_,
Array parameters_)
: executable_function(std::move(executable_function_))
, context(context_)
, context(std::move(context_))
{
const auto & configuration = executable_function->getConfiguration();
size_t command_parameters_size = configuration.parameters.size();
@ -230,6 +232,8 @@ private:
std::vector<std::string> command_arguments_with_parameters;
};
}
UserDefinedExecutableFunctionFactory & UserDefinedExecutableFunctionFactory::instance()
{
static UserDefinedExecutableFunctionFactory result;

View File

@ -58,7 +58,7 @@ public:
/// Pool size valid only if executable_pool = true
size_t pool_size = 16;
/// Max command execution time in milliseconds. Valid only if executable_pool = true
/// Max command execution time in seconds. Valid only if executable_pool = true
size_t max_command_execution_time_seconds = 10;
/// Should pool of processes be created.

View File

@ -179,8 +179,6 @@ namespace
void loadFromConfig(cppkafka::Configuration & conf, const Poco::Util::AbstractConfiguration & config, const std::string & path)
{
Poco::Util::AbstractConfiguration::Keys keys;
std::vector<char> errstr(512);
config.keys(path, keys);
for (const auto & key : keys)