diff --git a/src/DataTypes/Native.h b/src/DataTypes/Native.h index 9782c5d64e9..8f4a2abcff7 100644 --- a/src/DataTypes/Native.h +++ b/src/DataTypes/Native.h @@ -138,7 +138,7 @@ static inline llvm::Value * nativeBoolCast(llvm::IRBuilder<> & b, const DataType if (value->getType()->isIntegerTy()) return b.CreateICmpNE(value, zero); if (value->getType()->isFloatingPointTy()) - return b.CreateFCmpONE(value, zero); /// QNaN is false + return b.CreateFCmpUNE(value, zero); throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Cannot cast non-number {} to bool", from_type->getName()); } diff --git a/tests/queries/0_stateless/02525_jit_logical_functions_nan.reference b/tests/queries/0_stateless/02525_jit_logical_functions_nan.reference new file mode 100644 index 00000000000..98fb6a68656 --- /dev/null +++ b/tests/queries/0_stateless/02525_jit_logical_functions_nan.reference @@ -0,0 +1,4 @@ +1 +1 +1 +1 diff --git a/tests/queries/0_stateless/02525_jit_logical_functions_nan.sql b/tests/queries/0_stateless/02525_jit_logical_functions_nan.sql new file mode 100644 index 00000000000..6b4770c76ea --- /dev/null +++ b/tests/queries/0_stateless/02525_jit_logical_functions_nan.sql @@ -0,0 +1,9 @@ +SET min_count_to_compile_expression = 0; + +SELECT NOT NOT cos(MAX(pow(1523598955, 763027371))) FROM numbers(1) SETTINGS compile_expressions = 0; + +SELECT NOT NOT cos(MAX(pow(1523598955, 763027371))) FROM numbers(1) SETTINGS compile_expressions = 1; + +SELECT not(not(materialize(nan))) FROM numbers(1) SETTINGS compile_expressions = 0; + +SELECT not(not(materialize(nan))) FROM numbers(1) SETTINGS compile_expressions = 1;