thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Misc [#CLICKHOUSE-3].

Browse Source
This commit is contained in:
Alexey Milovidov 2017-03-21 21:39:07 +03:00
parent 9d5ea2163c
commit c21b4c52c5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dbms/src/Storages/AlterCommands.cpp
View File

@ -79,7 +79,7 @@ void AlterCommand::apply(
if (default_expression)
column_defaults.emplace(column_name, ColumnDefault{default_type, default_expression});
/// Slowly, because each time a list is copied
/// Slow, because each time a list is copied
columns = *DataTypeNested::expandNestedColumns(columns);
}
else if (type == DROP_COLUMN)
@ -163,7 +163,7 @@ void AlterCommand::apply(
}
else if (type == MODIFY_PRIMARY_KEY)
{
/// This does not apply to changing the list of columns.
/// This have no relation to changing the list of columns.
/// TODO Check that all columns exist, that only columns with constant defaults are added.
}
else

2
dbms/src/Storages/MergeTree/ActiveDataPartSet.cpp
View File

@ -35,7 +35,7 @@ void ActiveDataPartSet::addImpl(const String & name)
part.name = name;
parsePartName(name, part);
/// Parts contained in `part` are located inside `data_parts` in sequence, overlapping with place where the part itself would be inserted.
/// Parts contained in `part` are located contiguously inside `data_parts`, overlapping with the place where the part itself would be inserted.
Parts::iterator it = parts.lower_bound(part);
/// Let's go left.