More clang-tidy fixes

base/base/argsToConfig.h

@@ -4,7 +4,7 @@
 
 namespace Poco::Util
 {
-class LayeredConfiguration;
+class LayeredConfiguration; // NOLINT(cppcoreguidelines-virtual-class-destructor)
 }
 
 /// Import extra command line arguments to configuration. These are command line arguments after --.

base/base/iostream_debug_helpers.h

@@ -120,7 +120,7 @@ Out & dumpDispatchPriorities(Out & out, T && x, std::decay_t<decltype(dumpImpl<p
     return dumpImpl<priority>(out, x);
 }
 
-struct LowPriority { LowPriority(void *) {} };
+struct LowPriority { explicit LowPriority(void *) {} };
 
 template <int priority, typename Out, typename T>
 Out & dumpDispatchPriorities(Out & out, T && x, LowPriority)

base/base/strong_typedef.h

@@ -23,10 +23,10 @@ public:
     constexpr StrongTypedef(): t() {}
 
     constexpr StrongTypedef(const Self &) = default;
-    constexpr StrongTypedef(Self &&) = default;
+    constexpr StrongTypedef(Self &&) noexcept(std::is_nothrow_move_constructible_v<T>) = default;
 
     Self & operator=(const Self &) = default;
-    Self & operator=(Self &&) = default;
+    Self & operator=(Self &&) noexcept(std::is_nothrow_move_assignable_v<T>)= default;
 
     template <class Enable = typename std::is_copy_assignable<T>::type>
     Self & operator=(const T & rhs) { t = rhs; return *this;}

base/base/wide_integer.h

@@ -27,6 +27,8 @@
 #include <type_traits>
 #include <initializer_list>
 
+// NOLINTBEGIN(*)
+
 namespace wide
 {
 template <size_t Bits, typename Signed>
@@ -257,4 +259,7 @@ struct hash<wide::integer<Bits, Signed>>;
 
 }
 
+// NOLINTEND(*)
+
 #include "wide_integer_impl.h"
+

base/base/wide_integer_impl.h

@@ -15,6 +15,8 @@
 #include <boost/multiprecision/cpp_bin_float.hpp>
 #include <boost/math/special_functions/fpclassify.hpp>
 
+// NOLINTBEGIN(*)
+
 /// Use same extended double for all platforms
 #if (LDBL_MANT_DIG == 64)
 #define CONSTEXPR_FROM_DOUBLE constexpr
@@ -1478,3 +1480,5 @@ struct hash<wide::integer<Bits, Signed>>
 };
 
 }
+
+// NOLINTEND(*)

base/pcg-random/pcg_extras.hpp

@@ -1,5 +1,3 @@
-// NOLINTBEGIN(*)
-
 /*
  * PCG Random Number Generation for C++
  *
@@ -92,6 +90,7 @@
     #define PCG_EMULATED_128BIT_MATH 1
 #endif
 
+// NOLINTBEGIN(*)
 
 namespace pcg_extras {
 
@@ -554,6 +553,6 @@ std::ostream& operator<<(std::ostream& out, printable_typename<T>) {
 
 } // namespace pcg_extras
 
-#endif // PCG_EXTRAS_HPP_INCLUDED
-
 // NOLINTEND(*)
+
+#endif // PCG_EXTRAS_HPP_INCLUDED

base/pcg-random/pcg_random.hpp

@@ -1,5 +1,3 @@
-// NOLINTBEGIN(*)
-
 /*
  * PCG Random Number Generation for C++
  *
@@ -115,6 +113,8 @@
 
 #include "pcg_extras.hpp"
 
+// NOLINTBEGIN(*)
+
 namespace DB
 {
     struct PcgSerializer;
@@ -1779,6 +1779,6 @@ typedef pcg_engines::ext_oneseq_xsh_rs_64_32<14,32,true>    pcg32_k16384_fast;
     #pragma warning(default:4146)
 #endif
 
-#endif // PCG_RAND_HPP_INCLUDED
-
 // NOLINTEND(*)
+
+#endif // PCG_RAND_HPP_INCLUDED

base/widechar_width/widechar_width.h

@@ -16,6 +16,8 @@
 #include <cstddef>
 #include <cstdint>
 
+// NOLINTBEGIN(*)
+
 /* Special width values */
 enum {
   widechar_nonprint = -1,     // The character is not printable.
@@ -518,4 +520,6 @@ inline int widechar_wcwidth(wchar_t c) {
     return 1;
 }
 
+// NOLINTEND(*)
+
 #endif // WIDECHAR_WIDTH_H

src/Common/Exception.h

@@ -130,7 +130,7 @@ public:
     int getLineNumber() const { return line_number; }
     void setLineNumber(int line_number_) { line_number = line_number_;}
 
-    const String getFileName() const { return file_name; }
+    String getFileName() const { return file_name; }
     void setFileName(const String & file_name_) { file_name = file_name_; }
 
     Exception * clone() const override { return new ParsingException(*this); }

src/Common/FileCacheSettings.h

@@ -2,7 +2,7 @@
 
 #include <Common/FileCache_fwd.h>
 
-namespace Poco { namespace Util { class AbstractConfiguration; } }
+namespace Poco { namespace Util { class AbstractConfiguration; } } // NOLINT(cppcoreguidelines-virtual-class-destructor)
 
 namespace DB
 {

src/Common/IFactoryWithAliases.h

@@ -27,9 +27,9 @@ protected:
 
     String getAliasToOrName(const String & name) const
     {
-        if (aliases.count(name))
+        if (aliases.contains(name))
             return aliases.at(name);
-        else if (String name_lowercase = Poco::toLower(name); case_insensitive_aliases.count(name_lowercase))
+        else if (String name_lowercase = Poco::toLower(name); case_insensitive_aliases.contains(name_lowercase))
             return case_insensitive_aliases.at(name_lowercase);
         else
             return name;
@@ -108,7 +108,7 @@ public:
 
     bool isAlias(const String & name) const
     {
-        return aliases.count(name) || case_insensitive_aliases.count(name);
+        return aliases.count(name) || case_insensitive_aliases.contains(name);
     }
 
     bool hasNameOrAlias(const String & name) const
@@ -125,7 +125,7 @@ public:
         return name;
     }
 
-    virtual ~IFactoryWithAliases() override = default;
+    ~IFactoryWithAliases() override = default;
 
 private:
     using InnerMap = std::unordered_map<String, Value>; // name -> creator

src/Common/StringSearcher.h

@@ -7,8 +7,8 @@
 #include <Core/Defines.h>
 #include <base/range.h>
 #include <Poco/Unicode.h>
-#include <stdint.h>
-#include <string.h>
+#include <cstdint>
+#include <cstring>
 
 #ifdef __SSE2__
     #include <emmintrin.h>

src/Common/formatIPv6.h

@@ -1,7 +1,7 @@
 #pragma once
 
 #include <base/types.h>
-#include <string.h>
+#include <cstring>
 #include <algorithm>
 #include <utility>
 #include <base/range.h>

src/Core/Field.h

@@ -54,7 +54,7 @@ DEFINE_FIELD_VECTOR(Map); /// TODO: use map instead of vector.
 
 #undef DEFINE_FIELD_VECTOR
 
-using FieldMap = std::map<String, Field, std::less<String>, AllocatorWithMemoryTracking<std::pair<const String, Field>>>;
+using FieldMap = std::map<String, Field, std::less<>, AllocatorWithMemoryTracking<std::pair<const String, Field>>>;
 
 #define DEFINE_FIELD_MAP(X) \
 struct X : public FieldMap \

src/Databases/TablesLoader.h

@@ -12,7 +12,7 @@
 
 namespace Poco
 {
-    class Logger;
+    class Logger; // NOLINT(cppcoreguidelines-virtual-class-destructor)
 }
 
 class AtomicStopwatch;

src/Formats/FormatSettings.h

@@ -36,7 +36,7 @@ struct FormatSettings
     bool seekable_read = true;
     UInt64 max_rows_to_read_for_schema_inference = 100;
 
-    String column_names_for_schema_inference = "";
+    String column_names_for_schema_inference;
 
     enum class DateTimeInputFormat
     {

src/Interpreters/StorageID.h

@@ -10,7 +10,7 @@ namespace Poco
 {
 namespace Util
 {
-class AbstractConfiguration;
+class AbstractConfiguration; // NOLINT(cppcoreguidelines-virtual-class-destructor)
 }
 }
 

utils/iotest/iotest_aio.cpp

@@ -4,8 +4,8 @@ int main(int, char **) { return 0; }
 
 #include <fcntl.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <time.h>
+#include <cstdlib>
+#include <ctime>
 #include <iostream>
 #include <iomanip>
 #include <vector>
@@ -18,7 +18,7 @@ int main(int, char **) { return 0; }
 #include <pcg_random.hpp>
 #include <IO/BufferWithOwnMemory.h>
 #include <IO/ReadHelpers.h>
-#include <stdio.h>
+#include <cstdio>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <IO/AIO.h>

utils/self-extracting-executable/compressor.cpp

@@ -3,10 +3,10 @@
 #include <sys/mman.h>
 #include <fcntl.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <errno.h>
+#include <cstdlib>
+#include <cstdio>
+#include <cstring>
+#include <cerrno>
 #include <memory>
 #include <iostream>
 

utils/self-extracting-executable/decompressor.cpp

@@ -8,9 +8,9 @@
 #include <fcntl.h>
 #include <sys/wait.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
+#include <cstdlib>
+#include <cstdio>
+#include <cstring>
 #include <iostream>
 
 #include "types.h"