thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 16:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow only SELECT queries in EXPLAIN AST used inside subquery

Browse Source
This commit is contained in:
avogar 2024-11-15 14:20:05 +00:00
parent a2d37aba4d
commit c2543d0316
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Parsers/ExpressionElementParsers.cpp
View File

@ -140,6 +140,9 @@ bool ParserSubquery::parseImpl(Pos & pos, ASTPtr & node, Expected & expected)
const ASTPtr & explained_ast = explain_query.getExplainedQuery(); const ASTPtr & explained_ast = explain_query.getExplainedQuery();
if (explained_ast) if (explained_ast)
{ {
if (!explained_ast->as<ASTSelectWithUnionQuery>())
throw Exception(ErrorCodes::BAD_ARGUMENTS, "EXPLAIN inside subquery supports only SELECT queries");
auto view_explain = makeASTFunction("viewExplain", auto view_explain = makeASTFunction("viewExplain",
std::make_shared<ASTLiteral>(kind_str), std::make_shared<ASTLiteral>(kind_str),
std::make_shared<ASTLiteral>(settings_str), std::make_shared<ASTLiteral>(settings_str),

0
tests/queries/0_stateless/03273_select_from_explain_ast_non_select.reference Normal file
View File

4
tests/queries/0_stateless/03273_select_from_explain_ast_non_select.sql Normal file
View File

@ -0,0 +1,4 @@
SELECT * FROM ( EXPLAIN AST CREATE TABLE test ENGINE=Memory ); -- {clientError BAD_ARGUMENTS}
SELECT * FROM ( EXPLAIN AST CREATE MATERIALIZED VIEW mv (data String) AS SELECT data FROM table ); -- {clientError BAD_ARGUMENTS}
SELECT * FROM ( EXPLAIN AST INSERT INTO TABLE test VALUES); -- {clientError BAD_ARGUMENTS}
SELECT * FROM ( EXPLAIN AST ALTER TABLE test MODIFY COLUMN x UInt32 ); -- {clientError BAD_ARGUMENTS}