thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #47770 from ClickHouse/stop_wait_for_quorum_retries_on_shutdown

Browse Source 
Stop `wait for quorum` retries on shutdown
This commit is contained in:
Igor Nikonov 2023-03-27 18:27:14 +02:00 committed by GitHub
commit c2c7895b82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp
View File

@ -1073,13 +1073,26 @@ std::vector<String> ReplicatedMergeTreeSinkImpl<async_insert>::commitPart(
} }
}, },
[&zookeeper]() { zookeeper->cleanupEphemeralNodes(); }); [&zookeeper]() { zookeeper->cleanupEphemeralNodes(); });
if (!conflict_block_ids.empty()) if (!conflict_block_ids.empty())
return conflict_block_ids; return conflict_block_ids;
if (isQuorumEnabled()) if (isQuorumEnabled())
{ {
ZooKeeperRetriesControl quorum_retries_ctl("waitForQuorum", zookeeper_retries_info); ZooKeeperRetriesControl quorum_retries_ctl("waitForQuorum", zookeeper_retries_info);
quorum_retries_ctl.retryLoop([&]() quorum_retries_ctl.retryLoop([&]()
{ {
if (storage.is_readonly)
{
/// stop retries if in shutdown
if (storage.shutdown_called)
throw Exception(
ErrorCodes::TABLE_IS_READ_ONLY, "Table is in readonly mode due to shutdown: replica_path={}", storage.replica_path);
quorum_retries_ctl.setUserError(ErrorCodes::TABLE_IS_READ_ONLY, "Table is in readonly mode: replica_path={}", storage.replica_path);
return;
}
zookeeper->setKeeper(storage.getZooKeeper()); zookeeper->setKeeper(storage.getZooKeeper());
if (is_already_existing_part) if (is_already_existing_part)