thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix comments

Browse Source
This commit is contained in:
avogar 2022-02-07 17:07:44 +03:00
parent 34a17075d3
commit c3d30fd502
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Processors/Formats/Impl/MsgPackRowInputFormat.cpp
View File

@ -236,12 +236,9 @@ static void insertNull(IColumn & column, DataTypePtr type)
static void insertUUID(IColumn & column, DataTypePtr /*type*/, const char * value, size_t size)
{
ReadBufferFromMemory buf(value, size);
UInt64 first, second;
readBinaryBigEndian(first, buf);
readBinaryBigEndian(second, buf);
UUID uuid;
uuid.toUnderType().items[0] = first;
uuid.toUnderType().items[1] = second;
readBinaryBigEndian(uuid.toUnderType().items[0], buf);
readBinaryBigEndian(uuid.toUnderType().items[1], buf);
assert_cast<ColumnUUID &>(column).insertValue(uuid);
}
@ -353,8 +350,8 @@ bool MsgPackVisitor::visit_nil()
bool MsgPackVisitor::visit_ext(const char * value, uint32_t size)
{
uint8_t type = *value;
if (*value == 0x02)
int8_t type = *value;
if (*value == int8_t(MsgPackExtensionTypes::UUID))
{
insertUUID(info_stack.top().column, info_stack.top().type, value + 1, size - 1);
return true;
@ -497,7 +494,7 @@ DataTypePtr MsgPackSchemaReader::getDataType(const msgpack::object & object)
case msgpack::type::object_type::EXT:
{
msgpack::object_ext object_ext = object.via.ext;
if (object_ext.type() == 0x02)
if (object_ext.type() == int8_t(MsgPackExtensionTypes::UUID))
return std::make_shared<DataTypeUUID>();
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Msgpack extension type {} is not supported", object_ext.type());
}

5
src/Processors/Formats/Impl/MsgPackRowInputFormat.h
View File

@ -17,6 +17,11 @@ namespace DB
class ReadBuffer;
enum class MsgPackExtensionTypes
{
UUID = 0x02,
};
class MsgPackVisitor : public msgpack::null_visitor
{
public: