From c40ffb88c63dd37d83b6888133cabf54fc99aac3 Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@yandex-team.ru>
Date: Fri, 1 May 2020 22:18:35 +0300
Subject: [PATCH] Comments in config.xml; reset values for production use case

---
 programs/server/config.xml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/programs/server/config.xml b/programs/server/config.xml
index 831d7c4b6c6..c28a6c26dc7 100644
--- a/programs/server/config.xml
+++ b/programs/server/config.xml
@@ -139,11 +139,17 @@
 
     <!-- Simple server-wide memory profiler. Collect a stack trace at every peak allocation step (in bytes).
          Data will be stored in system.trace_log table with query_id = empty string.
-         Zero means disabled. Minimal effective value is 4 MiB.
+         Zero means disabled.
       -->
-    <total_memory_profiler_step>1</total_memory_profiler_step>
+    <total_memory_profiler_step>4194304</total_memory_profiler_step>
 
-    <total_memory_tracker_sample_probability>1</total_memory_tracker_sample_probability>
+    <!-- Collect random allocations and deallocations and write them into system.trace_log with 'MemorySample' trace_type.
+         The probability is for every alloc/free regardless to the size of the allocation.
+         Note that sampling happens only when the amount of untracked memory exceeds the untracked memory limit,
+          which is 4 MiB by default but can be lowered if 'total_memory_profiler_step' is lowered.
+         You may want to set 'total_memory_profiler_step' to 1 for extra fine grained sampling.
+      -->
+    <total_memory_tracker_sample_probability>0</total_memory_tracker_sample_probability>
 
     <!-- Set limit on number of open files (default: maximum). This setting makes sense on Mac OS X because getrlimit() fails to retrieve
          correct maximum value. -->