thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-19 12:52:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #65714 from ClickHouse/backport/24.6/65689

Browse Source 
Backport #65689 to 24.6: Fix crash in maxIntersections
This commit is contained in:
Raúl Marín 2024-06-27 13:25:50 +02:00 committed by GitHub
commit c417c2df68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/AggregateFunctions/AggregateFunctionMaxIntersections.cpp
View File

@ -91,7 +91,8 @@ public:
return std::make_shared<DataTypeNumber<PointType>>();
}
bool allocatesMemoryInArena() const override { return false; }
/// MaxIntersectionsData::Allocator uses the arena
bool allocatesMemoryInArena() const override { return true; }
void add(AggregateDataPtr __restrict place, const IColumn ** columns, size_t row_num, Arena * arena) const override
{

8
tests/queries/0_stateless/03196_max_intersections_arena_crash.reference Normal file
View File

@ -0,0 +1,8 @@
1 3 3
1 6 3
2 5 3
3 7 3
1 3 2
1 6 2
2 5 2
3 7 2

5
tests/queries/0_stateless/03196_max_intersections_arena_crash.sql Normal file
View File

@ -0,0 +1,5 @@
DROP TABLE IF EXISTS my_events;
CREATE TABLE my_events (start UInt32, end UInt32) Engine = MergeTree ORDER BY tuple()
AS Select * FROM VALUES ('start UInt32, end UInt32', (1, 3), (1, 6), (2, 5), (3, 7));
SELECT start, end, maxIntersections(start, end) OVER () FROM my_events;
SELECT start, end, maxIntersectionsPosition(start, end) OVER () FROM my_events;