thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #53573 from amosbird/fix_53454

Browse Source 
Proper destruction of task in ShellCommandSource
This commit is contained in:
Alexey Milovidov 2023-08-19 12:19:29 +03:00 committed by GitHub
commit c42c4046fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Processors/Sources/ShellCommandSource.cpp
View File

@ -349,7 +349,7 @@ namespace
{ {
for (auto && send_data_task : send_data_tasks) for (auto && send_data_task : send_data_tasks)
{ {
send_data_threads.emplace_back([task = std::move(send_data_task), this]() send_data_threads.emplace_back([task = std::move(send_data_task), this]() mutable
{ {
try try
{ {
@ -359,6 +359,10 @@ namespace
{ {
std::lock_guard lock(send_data_lock); std::lock_guard lock(send_data_lock);
exception_during_send_data = std::current_exception(); exception_during_send_data = std::current_exception();
/// task should be reset inside catch block or else it breaks d'tor
/// invariants such as in ~WriteBuffer.
task = {};
} }
}); });
} }