add workaround for memory leak

src/TableFunctions/CMakeLists.txt

@@ -7,6 +7,3 @@ list(REMOVE_ITEM clickhouse_table_functions_headers ITableFunction.h TableFuncti
 add_library(clickhouse_table_functions ${clickhouse_table_functions_sources})
 target_link_libraries(clickhouse_table_functions PRIVATE clickhouse_parsers clickhouse_storages_system dbms)
 
-if(ENABLE_TESTS)
-    add_subdirectory(tests)
-endif()

src/TableFunctions/TableFunctionNumbers.cpp

@@ -23,7 +23,8 @@ namespace ErrorCodes
 template <bool multithreaded>
 ColumnsDescription TableFunctionNumbers<multithreaded>::getActualTableStructure(const Context & /*context*/) const
 {
-    return ColumnsDescription({{"number", std::make_shared<DataTypeUInt64>()}});
+    /// NOTE: https://bugs.llvm.org/show_bug.cgi?id=47418
+    return ColumnsDescription{{{"number", std::make_shared<DataTypeUInt64>()}}};
 }
 
 template <bool multithreaded>

src/TableFunctions/TableFunctionZeros.cpp

@@ -22,7 +22,8 @@ extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
 template <bool multithreaded>
 ColumnsDescription TableFunctionZeros<multithreaded>::getActualTableStructure(const Context & /*context*/) const
 {
-    return ColumnsDescription({{"zero", std::make_shared<DataTypeUInt8>()}});
+    /// NOTE: https://bugs.llvm.org/show_bug.cgi?id=47418
+    return ColumnsDescription{{{"zero", std::make_shared<DataTypeUInt8>()}}};
 }
 
 template <bool multithreaded>

src/TableFunctions/tests/CMakeLists.txt

@@ -1,3 +0,0 @@
-add_executable (test-strange-memory-leak test_strange_memory_leak.cpp ${SRCS})
-#target_link_libraries (test-strange-memory-leak PRIVATE dbms)
-#target_link_libraries (test-strange-memory-leak PUBLIC boost::headers_only)

src/TableFunctions/tests/test_strange_memory_leak.cpp

@@ -1,136 +0,0 @@
-/// Demonstrates mysterious memory leak when built using clang version 10.0.0-4ubuntu1~18.04.2
-/// No leaks are found by valgrind when built using gcc version 9.2.1 20191102
-
-//#include <DataTypes/IDataType.h>
-//#include <Storages/ColumnsDescription.h>
-
-//class ITableFunction : public std::enable_shared_from_this<ITableFunction>
-//{
-//public:
-//    virtual DB::ColumnsDescription getActualTableStructure() const = 0;
-//    virtual ~ITableFunction() {}
-//
-//};
-//
-//class TableFunction : public ITableFunction
-//{
-//    DB::ColumnsDescription getActualTableStructure() const override
-//    {
-//        return DB::ColumnsDescription({{"number", DB::DataTypePtr{}}});
-//    }
-//};
-//
-//template <bool multithreaded>
-//class TableFunctionTemplate : public ITableFunction
-//{
-//    DB::ColumnsDescription getActualTableStructure() const override
-//    {
-//        return DB::ColumnsDescription({{"number", DB::DataTypePtr{}}});
-//    }
-//};
-
-/// Simplified version of the commented code above (without dependencies on ClickHouse code):
-
-#include <memory>
-#include <string>
-#include <list>
-#include <map>
-#include <iostream>
-//#include <boost/multi_index_container.hpp>
-//#include <boost/multi_index/sequenced_index.hpp>
-//#include <boost/multi_index/ordered_index.hpp>
-//#include <boost/multi_index/member.hpp>
-
-struct Print
-{
-    std::string data = "lol";
-    Print(const Print &) { std::cout << "copy" << std::endl; }
-    Print(Print &&) { std::cout << "move" << std::endl; }
-    Print & operator = (const Print &) { std::cout << "copy=" << std::endl; return *this; }
-    Print & operator = (Print &&) { std::cout << "move=" << std::endl; return *this; }
-    Print() { std::cout << "ctor" << std::endl; }
-    ~Print() { std::cout << "dtor" << std::endl; }
-};
-
-using LolPtr = std::shared_ptr<std::string>;
-struct Elem
-{
-    Elem(std::string n, LolPtr t) : name(std::move(n)), type(std::move(t)) {}
-    std::string name;
-    LolPtr type;
-    Print print;
-};
-
-//using Container = boost::multi_index_container<
-//        Elem,
-//        boost::multi_index::indexed_by<
-//                boost::multi_index::sequenced<>,
-//                boost::multi_index::ordered_unique<boost::multi_index::member<Elem, std::string, &Elem::name>>>>;
-/// Simplified version:
-using Container = std::map<std::string, Elem>;
-
-struct List : public std::list<Elem>
-{
-    List(std::initializer_list<Elem> init) : std::list<Elem>(init) {}
-};
-
-struct Kek
-{
-    Container container;
-    Kek(List list)
-    {
-        for (auto & elem : list)
-            add(Elem(std::move(elem.name), std::move(elem.type)));
-    }
-
-    void add(Elem column)
-    {
-        auto insert_it = container.cbegin();
-        //container.get<0>().insert(insert_it, std::move(column));
-        container.insert(insert_it, {column.name, column});
-    }
-
-};
-
-class ITableFunction : public std::enable_shared_from_this<ITableFunction>
-{
-public:
-    virtual Kek getActualTableStructure() const = 0;
-    virtual ~ITableFunction() {}
-
-};
-
-class TableFunction : public ITableFunction
-{
-    Kek getActualTableStructure() const override
-    {
-        return Kek({{"number", LolPtr{}}});
-    }
-};
-
-template <bool multithreaded>
-class TableFunctionTemplate : public ITableFunction
-{
-    Kek getActualTableStructure() const override
-    {
-        return Kek({{"number", LolPtr{}}});
-    }
-};
-
-int main()
-{
-    std::cout << "0" << std::endl;
-
-    /// Works fine
-    const ITableFunction & tf1 = TableFunction{};
-    tf1.getActualTableStructure();
-
-    std::cout << "1" << std::endl;
-
-    /// ERROR: LeakSanitizer: detected memory leaks
-    /// and the same error with valgrind
-    const ITableFunction & tf2 = TableFunctionTemplate<false>{};
-    tf2.getActualTableStructure();
-
-    std::cout << "2" << std::endl;
-}

src/TableFunctions/ya.make

@@ -23,7 +23,6 @@ SRCS(
     TableFunctionValues.cpp
     TableFunctionView.cpp
     TableFunctionZeros.cpp
-    tests/test_strange_memory_leak.cpp
 
 )
 

tests/config/lsan_suppressions.txt

@@ -1,2 +1,2 @@
-# See src/TableFunctions/tests/test-strange-memory-leak.cpp
+# See https://bugs.llvm.org/show_bug.cgi?id=47418
-leak:getActualTableStructure
+# leak:getActualTableStructure