thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-29 19:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cosmetics, pt. III

Browse Source
This commit is contained in:
Robert Schulze 2024-04-26 10:21:44 +00:00
parent c3be6728c8
commit c68a96eec3
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
2 changed files with 24 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Functions/generateUUIDv4.cpp
View File

@ -21,13 +21,10 @@ class FunctionGenerateUUIDv4 : public IFunction
public:
static constexpr auto name = "generateUUIDv4";
String getName() const override
{
return name;
}
String getName() const override { return name; }
size_t getNumberOfArguments() const override { return 0; }
bool isDeterministic() const override { return false; }
bool isDeterministicInScopeOfQuery() const override { return false; }
bool useDefaultImplementationForNulls() const override { return false; }
bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return false; }
@ -43,8 +40,6 @@ public:
return std::make_shared<DataTypeUUID>();
}
bool isDeterministic() const override { return false; }
ColumnPtr executeImpl(const ColumnsWithTypeAndName &, const DataTypePtr &, size_t input_rows_count) const override
{
auto col_res = ColumnVector<UUID>::create();

66
src/Functions/generateUUIDv7.cpp
View File

@ -83,7 +83,9 @@ namespace UUIDv7Impl
struct CounterDataCommon : UUIDv7Base
{
explicit CounterDataCommon(UUIDAsArray & u) : UUIDv7Base(u) { }
explicit CounterDataCommon(UUIDAsArray & u)
: UUIDv7Base(u)
{}
uint64_t getCounter()
{
@ -101,22 +103,16 @@ namespace UUIDv7Impl
uint64_t timestamp = 0;
/// Get timestamp of the previous uuid
for (int i = 0; i != 6; ++i)
{
timestamp = (timestamp << 8) | uuid[i];
}
const uint64_t unix_time_ms = getTimestampMs();
// continue incrementing counter when clock slightly goes back or when counter overflow happened during the previous UUID generation
bool need_to_increment_counter = (timestamp == unix_time_ms || timestamp < unix_time_ms + 10000);
uint64_t counter = 0;
if (need_to_increment_counter)
{
counter = getCounter();
}
else
{
timestamp = unix_time_ms;
}
bool counter_incremented = false;
if (need_to_increment_counter)
@ -157,7 +153,10 @@ namespace UUIDv7Impl
{
// Implement counter monotony only within one thread so function doesn't require mutexes and doesn't affect performance of the same function running simultenaously on other threads
static inline thread_local UUIDAsArray uuid_data;
Data() : CounterDataCommon(uuid_data) { }
Data()
: CounterDataCommon(uuid_data)
{}
};
};
@ -169,47 +168,32 @@ namespace UUIDv7Impl
// Implement counter monotony within one timestamp across all threads generating UUIDv7 with counter simultaneously
static inline UUIDAsArray uuid_data;
static inline std::mutex mtx;
Data() : std::lock_guard<std::mutex>(mtx), CounterDataCommon(uuid_data) { }
Data()
: std::lock_guard<std::mutex>(mtx)
, CounterDataCommon(uuid_data)
{}
};
};
}
template <typename FillPolicy>
class FunctionGenerateUUIDv7Base
: public IFunction,
public FillPolicy {
class FunctionGenerateUUIDv7Base : public IFunction, public FillPolicy
{
public:
using FillPolicy::name;
using FillPolicyData = typename FillPolicy::Data;
FunctionGenerateUUIDv7Base() = default;
String getName() const final
{
return name;
}
String getName() const final { return name; }
size_t getNumberOfArguments() const final
{
return 0;
}
bool isDeterministicInScopeOfQuery() const final
{
return false;
}
bool useDefaultImplementationForNulls() const final
{
return false;
}
bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const final
{
return false;
}
bool isVariadic() const final
{
return true;
}
size_t getNumberOfArguments() const final { return 0; }
bool isDeterministic() const override { return false; }
bool isDeterministicInScopeOfQuery() const final { return false; }
bool useDefaultImplementationForNulls() const final { return false; }
bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const final { return false; }
bool isVariadic() const final { return true; }
DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
{
@ -217,17 +201,11 @@ class FunctionGenerateUUIDv7Base
throw Exception(
ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH,
"Number of arguments for function {} doesn't match: passed {}, should be 0 or 1.",
getName(),
arguments.size());
getName(), arguments.size());
return std::make_shared<DataTypeUUID>();
}
bool isDeterministic() const override
{
return false;
}
ColumnPtr executeImpl(const ColumnsWithTypeAndName &, const DataTypePtr &, size_t input_rows_count) const override
{
auto col_res = ColumnVector<UUID>::create();