thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 16:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible crash in DataTypeAggregateFunction (#32287)

Browse Source
This commit is contained in:
Nikita Mikhaylov 2021-12-06 19:47:30 +03:00 committed by GitHub
parent f064f2cdaa
commit c92cfc38d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/DataTypes/DataTypeAggregateFunction.cpp
View File

@ -139,17 +139,20 @@ static DataTypePtr create(const ASTPtr & arguments)
if (!arguments || arguments->children.empty()) if (!arguments || arguments->children.empty())
throw Exception("Data type AggregateFunction requires parameters: " throw Exception("Data type AggregateFunction requires parameters: "
"name of aggregate function and list of data types for arguments", ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH); "version(optionally), name of aggregate function and list of data types for arguments", ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
ASTPtr data_type_ast = arguments->children[0]; ASTPtr data_type_ast = arguments->children[0];
size_t argument_types_start_idx = 1; size_t argument_types_start_idx = 1;
/* If aggregate function definition doesn't have version, it will have in AST children args [ASTFunction, types...] - in case /* If aggregate function definition doesn't have version, it will have in AST children args [ASTFunction, types...] - in case
* it is parametric, or [ASTIdentifier, types...] - otherwise. If aggregate function has version in AST, then it will be: * it is parametric, or [ASTIdentifier, types...] - otherwise. If aggregate function has version in AST, then it will be:
* [ASTLitearl, ASTFunction (or ASTIdentifier), types...]. * [ASTLiteral, ASTFunction (or ASTIdentifier), types...].
*/ */
if (auto * version_ast = arguments->children[0]->as<ASTLiteral>()) if (auto * version_ast = arguments->children[0]->as<ASTLiteral>())
{ {
if (arguments->children.size() < 2)
throw Exception(ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH,
"Data type AggregateFunction has version, but it requires at least one more parameter - name of aggregate function");
version = version_ast->value.safeGet<UInt64>(); version = version_ast->value.safeGet<UInt64>();
data_type_ast = arguments->children[1]; data_type_ast = arguments->children[1];
argument_types_start_idx = 2; argument_types_start_idx = 2;