thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prohibit cluster with zero weight across all shards

Browse Source 
Before it leads to SIGSEGV, due to either divizion by zero or an
a check in libdivide.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
Azat Khuzhin 2023-06-28 17:53:14 +02:00
parent 7f8ad3d5cb
commit c9adfe1efd
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Interpreters/Cluster.cpp
View File

@ -30,6 +30,7 @@ namespace ErrorCodes
extern const int SYNTAX_ERROR;
extern const int INVALID_SHARD_ID;
extern const int NO_SUCH_REPLICA;
extern const int BAD_ARGUMENTS;
}
namespace
@ -614,6 +615,12 @@ Poco::Timespan Cluster::saturate(Poco::Timespan v, Poco::Timespan limit)
void Cluster::initMisc()
{
/// NOTE: It is possible to have cluster w/o shards for
/// optimize_skip_unused_shards (i.e. WHERE 0 expression), so check the
/// slots only if shards is not empty.
if (!shards_info.empty() && slot_to_shard.empty())
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Cluster with zero weight on all shards is prohibited");
for (const auto & shard_info : shards_info)
{
if (!shard_info.isLocal() && !shard_info.hasRemoteConnections())