From caccc6da3787d4f328149ccae528328c165d4810 Mon Sep 17 00:00:00 2001
From: alesapin <alesapin@gmail.com>
Date: Mon, 15 Mar 2021 12:01:26 +0300
Subject: [PATCH] Add missing tests

---
 .../test_optimize_on_insert/__init__.py       |  1 +
 .../test_optimize_on_insert/test.py           | 48 +++++++++++++++++++
 ...560_optimize_on_insert_zookeeper.reference |  1 +
 .../01560_optimize_on_insert_zookeeper.sql    | 36 ++++++++++++++
 4 files changed, 86 insertions(+)
 create mode 100644 tests/integration/test_optimize_on_insert/__init__.py
 create mode 100644 tests/integration/test_optimize_on_insert/test.py
 create mode 100644 tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.reference
 create mode 100644 tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.sql

diff --git a/tests/integration/test_optimize_on_insert/__init__.py b/tests/integration/test_optimize_on_insert/__init__.py
new file mode 100644
index 00000000000..e5a0d9b4834
--- /dev/null
+++ b/tests/integration/test_optimize_on_insert/__init__.py
@@ -0,0 +1 @@
+#!/usr/bin/env python3
diff --git a/tests/integration/test_optimize_on_insert/test.py b/tests/integration/test_optimize_on_insert/test.py
new file mode 100644
index 00000000000..da4e20edf0c
--- /dev/null
+++ b/tests/integration/test_optimize_on_insert/test.py
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+import pytest
+from helpers.client import QueryRuntimeException
+from helpers.cluster import ClickHouseCluster
+
+cluster = ClickHouseCluster(__file__)
+node1 = cluster.add_instance('node1', with_zookeeper=True)
+node2 = cluster.add_instance('node2', with_zookeeper=True)
+
+@pytest.fixture(scope="module")
+def start_cluster():
+    try:
+        cluster.start()
+
+        yield cluster
+
+    finally:
+        cluster.shutdown()
+
+
+def get_data_files_for_table(node, table_name):
+    raw_output = node.exec_in_container(["bash", "-c", "ls /var/lib/clickhouse/data/default/{}".format(table_name)])
+    return raw_output.strip().split("\n")
+
+def test_empty_parts_optimize(start_cluster):
+    for n, node in enumerate([node1, node2]):
+        node.query("""
+            CREATE TABLE empty (key UInt32, val UInt32, date Datetime)
+            ENGINE=ReplicatedSummingMergeTree('/clickhouse/01560_optimize_on_insert', '{}', val)
+            PARTITION BY date ORDER BY key;
+        """.format(n+1))
+
+    node1.query("INSERT INTO empty VALUES (1, 1, '2020-01-01'), (1, 1, '2020-01-01'), (1, -2, '2020-01-01')")
+
+    node2.query("SYSTEM SYNC REPLICA empty", timeout=15)
+
+    assert node1.query("SELECT * FROM empty") == ""
+    assert node2.query("SELECT * FROM empty") == ""
+
+    # No other tmp files exists
+    assert set(get_data_files_for_table(node1, "empty")) == {"detached", "format_version.txt"}
+    assert set(get_data_files_for_table(node2, "empty")) == {"detached", "format_version.txt"}
+
+    node1.query("INSERT INTO empty VALUES (1, 1, '2020-02-01'), (1, 1, '2020-02-01'), (1, -2, '2020-02-01')", settings={"insert_quorum": 2})
+
+    assert node1.query("SELECT * FROM empty") == ""
+    assert node2.query("SELECT * FROM empty") == ""
diff --git a/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.reference b/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.reference
new file mode 100644
index 00000000000..e89c6201fb7
--- /dev/null
+++ b/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.reference
@@ -0,0 +1 @@
+Check creating empty parts
diff --git a/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.sql b/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.sql
new file mode 100644
index 00000000000..a98818b2195
--- /dev/null
+++ b/tests/queries/0_stateless/01560_optimize_on_insert_zookeeper.sql
@@ -0,0 +1,36 @@
+DROP TABLE IF EXISTS empty1;
+DROP TABLE IF EXISTS empty2;
+
+SELECT 'Check creating empty parts';
+
+CREATE TABLE empty1 (key UInt32, val UInt32, date Datetime)
+ENGINE=ReplicatedSummingMergeTree('/clickhouse/01560_optimize_on_insert', '1', val)
+PARTITION BY date ORDER BY key;
+
+CREATE TABLE empty2 (key UInt32, val UInt32, date Datetime)
+ENGINE=ReplicatedSummingMergeTree('/clickhouse/01560_optimize_on_insert', '2', val)
+PARTITION BY date ORDER BY key;
+
+INSERT INTO empty2 VALUES (1, 1, '2020-01-01'), (1, 1, '2020-01-01'), (1, -2, '2020-01-01');
+
+SYSTEM SYNC REPLICA empty1;
+
+SELECT * FROM empty1 ORDER BY key;
+SELECT * FROM empty2 ORDER BY key;
+
+SELECT table, partition, active FROM system.parts where table = 'empty1' and database=currentDatabase() and active = 1;
+SELECT table, partition, active FROM system.parts where table = 'empty2' and database=currentDatabase() and active = 1;
+
+DETACH table empty1;
+DETACH table empty2;
+ATTACH table empty1;
+ATTACH table empty2;
+
+SELECT * FROM empty1 ORDER BY key;
+SELECT * FROM empty2 ORDER BY key;
+
+SELECT table, partition, active FROM system.parts where table = 'empty1' and database=currentDatabase() and active = 1;
+SELECT table, partition, active FROM system.parts where table = 'empty2' and database=currentDatabase() and active = 1;
+
+DROP TABLE IF EXISTS empty1;
+DROP TABLE IF EXISTS empty2;