thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review fixes

Browse Source
This commit is contained in:
Alexey Milovidov 2021-03-28 01:57:59 +03:00
parent b3750b670f
commit cbf5913109
4 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/IO/MMapReadBufferFromFileDescriptor.cpp
View File

@ -45,12 +45,6 @@ MMapReadBufferFromFileDescriptor::MMapReadBufferFromFileDescriptor(int fd, size_
}
MMapReadBufferFromFileDescriptor::~MMapReadBufferFromFileDescriptor()
{
finish();
}
void MMapReadBufferFromFileDescriptor::finish()
{
mapped.finish();

2
src/IO/MMapReadBufferFromFileDescriptor.h
View File

@ -29,8 +29,6 @@ public:
/// Map till end of file.
MMapReadBufferFromFileDescriptor(int fd_, size_t offset_);
~MMapReadBufferFromFileDescriptor() override;
/// unmap memory before call to destructor
void finish();

2
src/IO/MappedFile.h
View File

@ -23,7 +23,7 @@ public:
/// Map till end of file.
MappedFile(const std::string & file_name_, size_t offset_);
~MappedFile();
~MappedFile() override;
void close();

2
src/IO/MappedFileDescriptor.h
View File

@ -17,7 +17,7 @@ public:
/// Makes empty object that can be initialized with `set`.
MappedFileDescriptor() {}
~MappedFileDescriptor();
virtual ~MappedFileDescriptor();
char * getData() { return data; }
const char * getData() const { return data; }