thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-24 10:40:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove memcpy and use the heap

Browse Source
This commit is contained in:
Raúl Marín 2021-08-30 11:42:02 +02:00
parent 5ad8e93458
commit d0f8e2d063
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/AggregateFunctions/AggregateFunctionSum.h
View File

@ -1,5 +1,6 @@
#pragma once #pragma once
#include <memory>
#include <experimental/type_traits> #include <experimental/type_traits>
#include <type_traits> #include <type_traits>
@ -400,12 +401,12 @@ public:
if (if_argument_pos >= 0) if (if_argument_pos >= 0)
{ {
/// Merge the 2 sets of flags (null and if) into a single one. This allows us to use parallelizable sums when available /// Merge the 2 sets of flags (null and if) into a single one. This allows us to use parallelizable sums when available
UInt8 final_flags[batch_size]; const auto * if_flags = assert_cast<const ColumnUInt8 &>(*columns[if_argument_pos]).getData().data();
memcpy(final_flags, assert_cast<const ColumnUInt8 &>(*columns[if_argument_pos]).getData().data(), batch_size * sizeof(UInt8)); auto final_flags = std::make_unique<UInt8[]>(batch_size);
for (size_t i = 0; i < batch_size; ++i) for (size_t i = 0; i < batch_size; ++i)
final_flags[i] = !null_map[i] && final_flags[i]; final_flags[i] = !null_map[i] && if_flags[i];
this->data(place).addManyConditional(column.getData().data(), final_flags, batch_size); this->data(place).addManyConditional(column.getData().data(), final_flags.get(), batch_size);
} }
else else
{ {