thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow accurate comparison of Big Int with other integers

Browse Source
This commit is contained in:
Alexey Milovidov 2023-02-08 07:56:00 +01:00
parent 8e407899ef
commit d66beb9ac4
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Common/FieldVisitorsAccurateComparison.h
View File

@ -45,20 +45,20 @@ public:
if constexpr (std::is_same_v<T, U>)
return l == r;
if constexpr (std::is_arithmetic_v<T> && std::is_arithmetic_v<U>)
if constexpr (is_arithmetic_v<T> && is_arithmetic_v<U>)
return accurate::equalsOp(l, r);
/// TODO This is wrong (does not respect scale).
if constexpr (is_decimal_field<T> && is_decimal_field<U>)
return l == r;
if constexpr (is_decimal_field<T> && std::is_arithmetic_v<U>)
if constexpr (is_decimal_field<T> && is_arithmetic_v<U>)
return l == DecimalField<Decimal256>(Decimal256(r), 0);
if constexpr (std::is_arithmetic_v<T> && is_decimal_field<U>)
if constexpr (is_arithmetic_v<T> && is_decimal_field<U>)
return DecimalField<Decimal256>(Decimal256(l), 0) == r;
if constexpr (std::is_same_v<T, String> && std::is_arithmetic_v<U>)
if constexpr (std::is_same_v<T, String> && is_arithmetic_v<U>)
{
ReadBufferFromString in(l);
U parsed;
@ -66,7 +66,7 @@ public:
return operator()(parsed, r);
}
if constexpr (std::is_same_v<U, String> && std::is_arithmetic_v<T>)
if constexpr (std::is_same_v<U, String> && is_arithmetic_v<T>)
{
ReadBufferFromString in(r);
T parsed;
@ -112,20 +112,20 @@ public:
if constexpr (std::is_same_v<T, U>)
return l < r;
if constexpr (std::is_arithmetic_v<T> && std::is_arithmetic_v<U>)
if constexpr (is_arithmetic_v<T> && is_arithmetic_v<U>)
return accurate::lessOp(l, r);
/// TODO This is wrong (does not respect scale).
if constexpr (is_decimal_field<T> && is_decimal_field<U>)
return l < r;
if constexpr (is_decimal_field<T> && std::is_arithmetic_v<U>)
if constexpr (is_decimal_field<T> && is_arithmetic_v<U>)
return l < DecimalField<Decimal256>(Decimal256(r), 0);
if constexpr (std::is_arithmetic_v<T> && is_decimal_field<U>)
if constexpr (is_arithmetic_v<T> && is_decimal_field<U>)
return DecimalField<Decimal256>(Decimal256(l), 0) < r;
if constexpr (std::is_same_v<T, String> && std::is_arithmetic_v<U>)
if constexpr (std::is_same_v<T, String> && is_arithmetic_v<U>)
{
ReadBufferFromString in(l);
U parsed;
@ -133,7 +133,7 @@ public:
return operator()(parsed, r);
}
if constexpr (std::is_same_v<U, String> && std::is_arithmetic_v<T>)
if constexpr (std::is_same_v<U, String> && is_arithmetic_v<T>)
{
ReadBufferFromString in(r);
T parsed;