diff --git a/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp b/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp index e10b848bfeb..541d03f5c20 100644 --- a/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp +++ b/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp @@ -126,7 +126,7 @@ SeekableReadBufferPtr CachedReadBufferFromRemoteFS::getCacheReadBuffer(size_t of local_read_settings.local_fs_method = LocalFSReadMethod::pread; auto buf = createReadBufferFromFileBase(path, local_read_settings); - auto from_fd = dynamic_cast(buf.get()); + auto * from_fd = dynamic_cast(buf.get()); if (from_fd && from_fd->size() == 0) throw Exception(ErrorCodes::LOGICAL_ERROR, "Attempt to read from an empty cache file: {}", path); diff --git a/src/Interpreters/ConvertFunctionOrLikeVisitor.cpp b/src/Interpreters/ConvertFunctionOrLikeVisitor.cpp index 7cad19fbf74..257bbda68eb 100644 --- a/src/Interpreters/ConvertFunctionOrLikeVisitor.cpp +++ b/src/Interpreters/ConvertFunctionOrLikeVisitor.cpp @@ -18,7 +18,7 @@ void ConvertFunctionOrLikeData::visit(ASTFunction & function, ASTPtr &) std::unordered_map> identifier_to_literals; for (auto & child : function.children) { - if (auto expr_list_fn = child->as()) + if (auto * expr_list_fn = child->as()) { ASTs unique_elems; for (const auto & child_expr_fn : expr_list_fn->children) @@ -41,7 +41,7 @@ void ConvertFunctionOrLikeData::visit(ASTFunction & function, ASTPtr &) /// Second one is string literal. auto identifier = arguments[0]; - auto literal = arguments[1]->as(); + auto * literal = arguments[1]->as(); if (!identifier || !literal || literal->value.getType() != Field::Types::String) continue; diff --git a/src/Interpreters/ConvertFunctionOrLikeVisitor.h b/src/Interpreters/ConvertFunctionOrLikeVisitor.h index ba4a0073448..f3da56eb60e 100644 --- a/src/Interpreters/ConvertFunctionOrLikeVisitor.h +++ b/src/Interpreters/ConvertFunctionOrLikeVisitor.h @@ -14,7 +14,7 @@ class ConvertFunctionOrLikeData public: using TypeToVisit = ASTFunction; - void visit(ASTFunction & function, ASTPtr & ast); + static void visit(ASTFunction & function, ASTPtr & ast); }; using ConvertFunctionOrLikeVisitor = InDepthNodeVisitor, true>; diff --git a/src/Processors/QueryPlan/AggregatingStep.cpp b/src/Processors/QueryPlan/AggregatingStep.cpp index d7d62d07d92..50acc085257 100644 --- a/src/Processors/QueryPlan/AggregatingStep.cpp +++ b/src/Processors/QueryPlan/AggregatingStep.cpp @@ -205,7 +205,7 @@ void AggregatingStep::transformPipeline(QueryPipelineBuilder & pipeline, const B for (size_t set_counter = 0; set_counter < grouping_sets_size; ++set_counter) { - auto & header = ports[set_counter]->getHeader(); + const auto & header = ports[set_counter]->getHeader(); /// Here we create a DAG which fills missing keys and adds `__grouping_set` column auto dag = std::make_shared(header.getColumnsWithTypeAndName());