thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip virtual row chunk by skipping last row.

Browse Source
This commit is contained in:
Nikolai Kochetov 2024-09-26 16:12:18 +00:00
parent d5c0c499df
commit d6b444dac9
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Processors/Merges/Algorithms/MergingSortedAlgorithm.cpp
View File

@ -63,6 +63,7 @@ void MergingSortedAlgorithm::initialize(Inputs inputs)
continue;
setVirtualRow(input.chunk, header, apply_virtual_row_conversions);
input.skip_last_row = true;
}
removeConstAndSparse(inputs);
@ -149,8 +150,8 @@ IMergingAlgorithm::Status MergingSortedAlgorithm::mergeImpl(TSortingHeap & queue
auto current = queue.current();
if (isVirtualRow(current_inputs[current.impl->order].chunk))
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Virtual row is not implemented for Non-batch mode.");
// if (isVirtualRow(current_inputs[current.impl->order].chunk))
// throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Virtual row is not implemented for Non-batch mode.");
if (current.impl->isLast() && current_inputs[current.impl->order].skip_last_row)
{
@ -248,14 +249,14 @@ IMergingAlgorithm::Status MergingSortedAlgorithm::mergeBatchImpl(TSortingQueue &
auto [current_ptr, initial_batch_size] = queue.current();
auto current = *current_ptr;
if (isVirtualRow(current_inputs[current.impl->order].chunk))
{
/// If virtual row is detected, there should be only one row as a single chunk,
/// and always skip this chunk to pull the next one.
chassert(initial_batch_size == 1);
queue.removeTop();
return Status(current.impl->order);
}
// if (isVirtualRow(current_inputs[current.impl->order].chunk))
// {
// /// If virtual row is detected, there should be only one row as a single chunk,
// /// and always skip this chunk to pull the next one.
// chassert(initial_batch_size == 1);
// queue.removeTop();
// return Status(current.impl->order);
// }
bool batch_skip_last_row = false;
if (current.impl->isLast(initial_batch_size) && current_inputs[current.impl->order].skip_last_row)