thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge b8d5a82f97 into f4038e3153

Browse Source
This commit is contained in:
János Benjamin Antal 2024-08-28 02:16:49 +02:00 committed by GitHub
commit d6ba33cffa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/en/operations/settings/settings.md
View File

@ -3226,7 +3226,7 @@ Default value: `0`.
## lightweight_deletes_sync {#lightweight_deletes_sync}
The same as 'mutation_sync', but controls only execution of lightweight deletes.
The same as [`mutations_sync`](#mutations_sync), but controls only execution of lightweight deletes.
Possible values:

5
src/Storages/MutationCommands.cpp
View File

@ -115,7 +115,10 @@ std::optional<MutationCommand> MutationCommand::parse(ASTAlterCommand * command,
res.column_name = getIdentifierName(command->column);
return res;
}
else if (parse_alter_commands && command->type == ASTAlterCommand::MODIFY_COLUMN)
/// MODIFY COLUMN x REMOVE MATERIALIZED is a valid alter command, but doesn't have any specified column type, thus no mutation is needed
else if (
parse_alter_commands && command->type == ASTAlterCommand::MODIFY_COLUMN && command->col_decl
&& command->col_decl->as<ASTColumnDeclaration &>().type)
{
MutationCommand res;
res.ast = command->ptr();

4
tests/queries/0_stateless/03230_alter_with_mixed_mutations_and_remove_materialized.reference Normal file
View File

@ -0,0 +1,4 @@
BEFORE a x String
BEFORE a y String MATERIALIZED \'str\'
AFTER a x String
AFTER a y String

13
tests/queries/0_stateless/03230_alter_with_mixed_mutations_and_remove_materialized.sql Normal file
View File

@ -0,0 +1,13 @@
DROP TABLE IF EXISTS a SYNC;
CREATE TABLE a (x String, y String MATERIALIZED 'str') ENGINE = ReplicatedMergeTree('/clickhouse/{database}/a', 'r1') ORDER BY x;
INSERT INTO a SELECT toString(number) FROM numbers(100);
SELECT 'BEFORE', table, name, type, default_kind, default_expression FROM system.columns WHERE database = currentDatabase() AND table = 'a' ORDER BY table, name;
-- DROP INDEX is important to make the mutation not a pure metadata mutation
ALTER TABLE a
DROP INDEX IF EXISTS some_index,
MODIFY COLUMN y REMOVE MATERIALIZED
SETTINGS alter_sync = 2, mutations_sync = 2;
SELECT 'AFTER', table, name, type, default_kind, default_expression FROM system.columns WHERE database = currentDatabase() AND table = 'a' ORDER BY table, name;