thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow Array/OrNull combinators regardless nesting

Browse Source
This commit is contained in:
Azat Khuzhin 2021-09-10 21:03:15 +03:00
parent 1e7714d56d
commit d8bf2f81ec
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/AggregateFunctions/AggregateFunctionFactory.cpp
View File

@ -180,9 +180,21 @@ AggregateFunctionPtr AggregateFunctionFactory::getImpl(
/// need to filter aggregation result based on another column for
/// example.
if (nested_name.ends_with(combinator_name))
throw Exception(ErrorCodes::ILLEGAL_AGGREGATION,
"Nested identical combinator '{}' is not supported",
combinator_name);
{
/// But the following combinators are allowed regardless nesting:
/// - Array
/// - OrNull (due to aggregate_functions_null_for_empty)
if (combinator_name == "Array" || combinator_name == "OrNull")
{
/// Is supported.
}
else
{
throw Exception(ErrorCodes::ILLEGAL_AGGREGATION,
"Nested identical combinator '{}' is not supported",
combinator_name);
}
}
DataTypes nested_types = combinator->transformArguments(argument_types);
Array nested_parameters = combinator->transformParameters(parameters);