thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

ISSUES-1386 add logical error when drop exist depend

Browse Source
This commit is contained in:
zhang2014 2018-02-21 08:49:16 +08:00
parent d0bfa15525
commit dc189fd129
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dbms/src/Storages/AlterCommands.cpp
View File

@ -265,6 +265,18 @@ void AlterCommands::validate(IStorage * table, const Context & context)
}
else if (command.type == AlterCommand::DROP_COLUMN)
{
for (const auto default_column : defaults)
{
const auto default_expression = default_column.second.expression;
const auto actions = ExpressionAnalyzer{default_expression, context, {}, columns}.getActions(true);
const auto require_columns = actions->getRequiredColumns();
if (std::count(require_columns.begin(), require_columns.end(), command.column_name))
throw Exception(
"Cannot drop column " + command.column_name + ", Because column " + default_column.first +
" depends on it", DB::ErrorCodes::LOGICAL_ERROR
);
}
auto found = false;
for (auto it = std::begin(columns); it != std::end(columns);)
if (AlterCommand::namesEqual(command.column_name, *it))