thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

dbms: fixed error [#METR-19271].

Browse Source
This commit is contained in:
Alexey Milovidov 2015-12-08 04:17:57 +03:00
parent 35db0d65b9
commit dc7372ab71
3 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
dbms/include/DB/Columns/ColumnConst.h
View File

@ -26,6 +26,29 @@ public:
};
namespace ColumnConstDetails
{
template <typename T>
inline bool equals(const T & x, const T & y)
{
return x == y;
}
/// Проверяет побитовую идентичность элементов, даже если они являются NaN-ами.
template <>
inline bool equals(const Float32 & x, const Float32 & y)
{
return 0 == memcmp(&x, &y, sizeof(x));
}
template <>
inline bool equals(const Float64 & x, const Float64 & y)
{
return 0 == memcmp(&x, &y, sizeof(x));
}
}
/** Столбец-константа может содержать внутри себя само значение,
* или, в случае массивов, SharedPtr от значения-массива,
* чтобы избежать проблем производительности при копировании очень больших массивов.
@ -65,7 +88,7 @@ public:
void insertRangeFrom(const IColumn & src, size_t start, size_t length) override
{
if (getDataFromHolder() != static_cast<const Derived &>(src).getDataFromHolder())
if (!ColumnConstDetails::equals(getDataFromHolder(), static_cast<const Derived &>(src).getDataFromHolder()))
throw Exception("Cannot insert different element into constant column " + getName(),
ErrorCodes::CANNOT_INSERT_ELEMENT_INTO_CONSTANT_COLUMN);
@ -74,7 +97,7 @@ public:
void insert(const Field & x) override
{
if (x.get<FieldType>() != FieldType(getDataFromHolder()))
if (!ColumnConstDetails::equals(x.get<FieldType>(), FieldType(getDataFromHolder())))
throw Exception("Cannot insert different element into constant column " + getName(),
ErrorCodes::CANNOT_INSERT_ELEMENT_INTO_CONSTANT_COLUMN);
++s;
@ -87,7 +110,7 @@ public:
void insertFrom(const IColumn & src, size_t n) override
{
if (getDataFromHolder() != static_cast<const Derived &>(src).getDataFromHolder())
if (!ColumnConstDetails::equals(getDataFromHolder(), static_cast<const Derived &>(src).getDataFromHolder()))
throw Exception("Cannot insert different element into constant column " + getName(),
ErrorCodes::CANNOT_INSERT_ELEMENT_INTO_CONSTANT_COLUMN);
++s;

1
dbms/tests/queries/0_stateless/00287_column_const_with_nan.reference Normal file
View File

@ -0,0 +1 @@
nan 1

1
dbms/tests/queries/0_stateless/00287_column_const_with_nan.sql Normal file
View File

@ -0,0 +1 @@
SELECT * FROM (SELECT nan, number FROM system.numbers) WHERE number % 100 = 1 LIMIT 1;