thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 19:42:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check proper sorting in debug builds

Browse Source
This commit is contained in:
Alexander Gololobov 2024-11-25 13:20:47 +01:00
parent 140f5987da
commit dcd07e25ac
1 changed files with 58 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/Interpreters/sortBlock.cpp
View File

@ -272,6 +272,56 @@ bool isAlreadySortedImpl(size_t rows, Comparator compare)
return true; return true;
} }
template <typename Comparator>
void checkSortedWithPermutationImpl(size_t rows, Comparator compare, UInt64 limit, const IColumn::Permutation & permutation)
{
if (limit && limit < rows)
rows = limit;
for (size_t i = 1; i < rows; ++i)
{
const size_t current_row = permutation[i];
const size_t previous_row = permutation[i - 1];
if (compare(current_row, previous_row))
throw Exception(ErrorCodes::LOGICAL_ERROR,
"Rows are not sorted with permuation, position {}, previous_row index {}, current_row index {}", i, previous_row, current_row);
}
}
void checkSortedWithPermutation(const Block & block, const SortDescription & description, UInt64 limit, const IColumn::Permutation & permutation)
{
if (!block)
return;
ColumnsWithSortDescriptions columns_with_sort_desc = getColumnsWithSortDescription(block, description);
bool is_collation_required = false;
for (auto & column_with_sort_desc : columns_with_sort_desc)
{
if (isCollationRequired(column_with_sort_desc.description))
{
is_collation_required = true;
break;
}
}
size_t rows = block.rows();
if (is_collation_required)
{
PartialSortingLessWithCollation less(columns_with_sort_desc);
checkSortedWithPermutationImpl(rows, less, limit, permutation);
return;
}
else
{
PartialSortingLess less(columns_with_sort_desc);
checkSortedWithPermutationImpl(rows, less, limit, permutation);
return;
}
}
} }
void sortBlock(Block & block, const SortDescription & description, UInt64 limit) void sortBlock(Block & block, const SortDescription & description, UInt64 limit)
@ -279,6 +329,10 @@ void sortBlock(Block & block, const SortDescription & description, UInt64 limit)
IColumn::Permutation permutation; IColumn::Permutation permutation;
getBlockSortPermutationImpl(block, description, IColumn::PermutationSortStability::Unstable, limit, permutation); getBlockSortPermutationImpl(block, description, IColumn::PermutationSortStability::Unstable, limit, permutation);
#ifndef NDEBUG
checkSortedWithPermutation(block, description, limit, permutation);
#endif
if (permutation.empty()) if (permutation.empty())
return; return;
@ -303,6 +357,10 @@ void stableGetPermutation(const Block & block, const SortDescription & descripti
return; return;
getBlockSortPermutationImpl(block, description, IColumn::PermutationSortStability::Stable, 0, out_permutation); getBlockSortPermutationImpl(block, description, IColumn::PermutationSortStability::Stable, 0, out_permutation);
#ifndef NDEBUG
checkSortedWithPermutation(block, description, 0, out_permutation);
#endif
} }
bool isAlreadySorted(const Block & block, const SortDescription & description) bool isAlreadySorted(const Block & block, const SortDescription & description)