Fix test

src/DataStreams/IBlockOutputStream.h

@@ -21,7 +21,7 @@ struct Progress;
 class IBlockOutputStream : private boost::noncopyable
 {
 public:
-    IBlockOutputStream() {}
+    IBlockOutputStream() = default;
 
     /** Get data structure of the stream in a form of "header" block (it is also called "sample block").
       * Header block contains column names, data types, columns of size 0. Constant columns must have corresponding values.

src/Functions/IFunction.cpp

@@ -477,6 +477,7 @@ DataTypePtr FunctionOverloadResolverAdaptor::getReturnTypeDefaultImplementationF
     }
     if (null_presence.has_nullable)
     {
+        /// FIXME: is it really necessary to convert to and from Block?
         Block nested_columns = createBlockWithNestedColumns(arguments);
         auto return_type = getter(ColumnsWithTypeAndName(nested_columns.begin(), nested_columns.end()));
         return makeNullable(return_type);

src/Interpreters/InterpreterInsertQuery.cpp

@@ -407,7 +407,7 @@ BlockIO InterpreterInsertQuery::execute()
 
     if (!out_streams.empty())
     {
-        assert(res.in);
+        /// FIXME: assert(res.in); // this assert doesn't work just because of SystemLog<>::flushImpl()
         res.out = std::move(out_streams.at(0));
     }
     else

src/Interpreters/SystemLog.h

@@ -446,9 +446,8 @@ void SystemLog<LogElement>::flushImpl(const std::vector<LogElement> & to_flush,
         /// We write to table indirectly, using InterpreterInsertQuery.
         /// This is needed to support DEFAULT-columns in table.
 
-        std::unique_ptr<ASTInsertQuery> insert = std::make_unique<ASTInsertQuery>();
-        insert->table_id = table_id;
-        ASTPtr query_ptr(insert.release());
+        ASTPtr query_ptr = std::make_shared<ASTInsertQuery>();
+        query_ptr->as<ASTInsertQuery>()->table_id = table_id;
 
         // we need query context to do inserts to target table with MV containing subqueries or joins
         Context insert_context(context);