thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use ORDER BY for empty key

Browse Source
This commit is contained in:
alesapin 2020-02-07 20:10:24 +03:00
parent 1ada6e663c
commit dea937ad84
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
dbms/src/Interpreters/MutationsInterpreter.cpp
View File

@ -534,16 +534,30 @@ ASTPtr MutationsInterpreter::prepareInterpreterSelectQuery(std::vector<Stage> &
if (metadata.order_by_ast)
{
ASTPtr dummy;
auto order_by_expr = std::make_shared<ASTOrderByElement>(1, 0, false, dummy, false, dummy, dummy, dummy);
ASTPtr key_expr;
if (metadata.primary_key_ast)
order_by_expr->children.push_back(metadata.primary_key_ast);
key_expr = metadata.primary_key_ast;
else
order_by_expr->children.push_back(metadata.order_by_ast);
key_expr = metadata.order_by_ast;
auto res = std::make_shared<ASTExpressionList>();
res->children.push_back(order_by_expr);
bool empty = false;
/// In all other cases we cannot have empty key
if (auto key_function = key_expr->as<ASTFunction>())
empty = key_function->arguments->children.size() == 0;
select->setExpression(ASTSelectQuery::Expression::ORDER_BY, std::move(res));
/// Not explicitely spicified empty key
if (!empty)
{
auto order_by_expr = std::make_shared<ASTOrderByElement>(1, 1, false, dummy, false, dummy, dummy, dummy);
order_by_expr->children.push_back(key_expr);
auto res = std::make_shared<ASTExpressionList>();
res->children.push_back(order_by_expr);
select->setExpression(ASTSelectQuery::Expression::ORDER_BY, std::move(res));
}
}
return select;