thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

add least and greatest funcs for decimal

Browse Source
This commit is contained in:
chertus 2018-08-03 17:46:02 +03:00
parent a5a7dc0fdd
commit e31e4e164f
3 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dbms/src/Functions/FunctionsArithmetic.h
View File

@ -704,12 +704,14 @@ struct DecimalBinaryOperation
static constexpr bool is_plus_minus = std::is_same_v<Op, PlusImpl<ResultType, ResultType>> ||
std::is_same_v<Op, MinusImpl<ResultType, ResultType>>;
static constexpr bool is_division = std::is_same_v<Op, DivideFloatingImpl<ResultType, ResultType>>;
static constexpr bool is_compare = std::is_same_v<Op, LeastBaseImpl<ResultType, ResultType>> ||
std::is_same_v<Op, GreatestBaseImpl<ResultType, ResultType>>;
static void NO_INLINE vector_vector(const PaddedPODArray<A> & a, const PaddedPODArray<B> & b, PaddedPODArray<ResultType> & c,
ResultType scale_a [[maybe_unused]], ResultType scale_b [[maybe_unused]])
{
size_t size = a.size();
if constexpr (is_plus_minus)
if constexpr (is_plus_minus || is_compare)
{
if (scale_a != 1)
{
@ -740,7 +742,7 @@ struct DecimalBinaryOperation
ResultType scale_a [[maybe_unused]], ResultType scale_b [[maybe_unused]])
{
size_t size = a.size();
if constexpr (is_plus_minus)
if constexpr (is_plus_minus || is_compare)
{
if (scale_a != 1)
{
@ -771,7 +773,7 @@ struct DecimalBinaryOperation
ResultType scale_a [[maybe_unused]], ResultType scale_b [[maybe_unused]])
{
size_t size = b.size();
if constexpr (is_plus_minus)
if constexpr (is_plus_minus || is_compare)
{
if (scale_a != 1)
{
@ -800,7 +802,7 @@ struct DecimalBinaryOperation
static ResultType constant_constant(A a, B b, ResultType scale_a [[maybe_unused]], ResultType scale_b [[maybe_unused]])
{
if constexpr (is_plus_minus)
if constexpr (is_plus_minus || is_compare)
return Op::template apply<ResultType>(a * scale_a, b * scale_b);
else if constexpr (is_division)
return Op::template apply<ResultType>(a * scale_a, b);
@ -856,7 +858,9 @@ public:
std::is_same_v<Operation<T0, T0>, PlusImpl<T0, T0>> ||
std::is_same_v<Operation<T0, T0>, MinusImpl<T0, T0>> ||
std::is_same_v<Operation<T0, T0>, MultiplyImpl<T0, T0>> ||
std::is_same_v<Operation<T0, T0>, DivideFloatingImpl<T0, T0>>;
std::is_same_v<Operation<T0, T0>, DivideFloatingImpl<T0, T0>> ||
std::is_same_v<Operation<T0, T0>, LeastBaseImpl<T0, T0>> ||
std::is_same_v<Operation<T0, T0>, GreatestBaseImpl<T0, T0>>;
/// Appropriate result type for binary operator on numeric types. "Date" can also mean
/// DateTime, but if both operands are Dates, their type must be the same (e.g. Date - DateTime is invalid).

6
dbms/tests/queries/0_stateless/00700_decimal_compare.reference
View File

@ -15,3 +15,9 @@
42 42 42
42 42 42
42 42 42
-42 -42.42000 -42 -42.00000
42 42.00000 42 42.42000
-42 -42 -42.42000
0 0 0.00000
0 0 0.00000
42 42 42.42000

4
dbms/tests/queries/0_stateless/00700_decimal_compare.sql
View File

@ -40,4 +40,8 @@ SELECT a, b, c FROM test.decimal WHERE a = toInt64(42) AND b = toInt64(42) AND c
SELECT a, b, c FROM test.decimal WHERE a = toFloat32(42); -- { serverError 43 }
SELECT a, b, c FROM test.decimal WHERE a = toFloat64(42); -- { serverError 43 }
SELECT least(a, b), least(a, g), greatest(a, b), greatest(a, g) FROM test.decimal ORDER BY a;
SELECT least(a, 0), least(b, 0), least(g, 0) FROM test.decimal ORDER BY a;
SELECT greatest(a, 0), greatest(b, 0), greatest(g, 0) FROM test.decimal ORDER BY a;
DROP TABLE IF EXISTS test.decimal;