From e3502dabc79e40d169306a2d195ec8b85cce6c6f Mon Sep 17 00:00:00 2001 From: Dmitry Krylov Date: Tue, 16 Mar 2021 18:41:28 +1000 Subject: [PATCH] Remove debug messages --- src/Functions/array/FunctionArrayMapped.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Functions/array/FunctionArrayMapped.h b/src/Functions/array/FunctionArrayMapped.h index eacecd9da4c..bd60ac9580f 100644 --- a/src/Functions/array/FunctionArrayMapped.h +++ b/src/Functions/array/FunctionArrayMapped.h @@ -157,7 +157,7 @@ public: { const ColumnConst * column_const_array = checkAndGetColumnConst(column_array_ptr.get()); if (!column_const_array) - throw Exception("X1 Expected array column, found " + column_array_ptr->getName(), ErrorCodes::ILLEGAL_COLUMN); + throw Exception("Expected array column, found " + column_array_ptr->getName(), ErrorCodes::ILLEGAL_COLUMN); column_array_ptr = column_const_array->convertToFullColumn(); column_array = assert_cast(column_array_ptr.get()); } @@ -233,17 +233,16 @@ public: array_with_type_and_name.name)); } if (Impl::isFolding()) - arrays.emplace_back(arguments[arguments.size() - 1]); // TODO .last() + arrays.emplace_back(arguments.back()); - if (Impl::isFolding() && (column_first_array->getData().size() > 0)) // TODO .size() -> .empty() + if (Impl::isFolding() && (! column_first_array->getData().empty())) { size_t arr_cursor = 0; MutableColumnPtr result = arguments.back().column->convertToFullColumnIfConst()->cloneEmpty(); for (size_t irow = 0; irow < column_first_array->size(); ++irow) // for each row of result { // Make accumulator column for this row - // TODO проверить с константой - ColumnWithTypeAndName accumulator_column = arguments.back(); // TODO тут нужно ещё и позицию в аргументе извлекать + ColumnWithTypeAndName accumulator_column = arguments.back(); ColumnPtr acc(accumulator_column.column->cut(irow, 1)); auto accumulator = ColumnWithTypeAndName(acc, accumulator_column.type,