thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 10:02:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flakiness of test_distributed_load_balancing

Browse Source 
I saw the following in the logs for the failed test:

    2023.05.16 07:12:12.894051 [ 262 ] {74575ac0-b296-4fdc-bc8e-3476a305e6ea} <Warning> ConnectionPoolWithFailover: Connection failed at try №1, reason: Timeout exceeded while reading from socket (socket (172.16.3.2:9000), receive timeout 2000 ms)

And I think that the culprit is the
test_distributed_replica_max_ignored_errors for which it is normal,
however not for others, and this should not affect other tests.

So fix this by calling SYSTEM RELOAD CONFIG, which should reset error
count.

CI: https://s3.amazonaws.com/clickhouse-test-reports/49380/5abc1a1c68ee204c9024493be1d19835cf5630f7/integration_tests__release__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
Azat Khuzhin 2023-05-16 15:57:26 +02:00
parent e84f0895e7
commit e37e8f83bb
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/integration/test_distributed_load_balancing/test.py
View File

@ -29,23 +29,19 @@ nodes = len(cluster.instances)
queries = nodes * 10 queries = nodes * 10
def bootstrap(): # SYSTEM RELOAD CONFIG will reset some attributes of the nodes in cluster
for n in list(cluster.instances.values()):
# At startup, server loads configuration files.
#
# However ConfigReloader does not know about already loaded files
# (files is empty()), hence it will always reload the configuration
# just after server starts (+ 2 seconds, reload timeout).
#
# And on configuration reload the clusters will be re-created, so some
# internal stuff will be reset:
# - error_count # - error_count
# - last_used (round_robing) # - last_used (round_robing)
# #
# And if the reload will happen during round_robin test it will start # This is required to avoid interference results of one test to another
# querying from the beginning, so let's issue config reload just after @pytest.fixture(scope="function", autouse=True)
# start to avoid reload in the middle of the test execution. def test_setup():
for n in list(cluster.instances.values()):
n.query("SYSTEM RELOAD CONFIG") n.query("SYSTEM RELOAD CONFIG")
def bootstrap():
for n in list(cluster.instances.values()):
n.query("DROP TABLE IF EXISTS data") n.query("DROP TABLE IF EXISTS data")
n.query("DROP TABLE IF EXISTS dist") n.query("DROP TABLE IF EXISTS dist")
n.query("CREATE TABLE data (key Int) Engine=Memory()") n.query("CREATE TABLE data (key Int) Engine=Memory()")