thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

hex/bin functions support AggregateFunction states.

Browse Source
This commit is contained in:
zxc111 2021-07-09 00:19:42 +08:00
parent 9c2aad6c17
commit e4b1e0619c
3 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Functions/FunctionsCoding.h
View File

@ -25,6 +25,7 @@
#include <Common/hex.h>
#include <Common/typeid_cast.h>
#include <Common/BitHelpers.h>
#include <Functions/FunctionFactory.h>
#include <arpa/inet.h>
#include <common/range.h>
@ -954,6 +955,8 @@ public:
template <typename Impl>
class EncodeToBinaryRepr : public IFunction
{
private:
ContextPtr context;
public:
static constexpr auto name = Impl::name;
static constexpr size_t word_size = Impl::word_size;
@ -978,18 +981,29 @@ public:
!which.isDateTime64() &&
!which.isUInt() &&
!which.isFloat() &&
!which.isDecimal())
!which.isDecimal() &&
!which.isAggregateFunction())
throw Exception("Illegal type " + arguments[0]->getName() + " of argument of function " + getName(),
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
return std::make_shared<DataTypeString>();
}
ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr &, size_t /*input_rows_count*/) const override
ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type, size_t input_rows_count) const override
{
const IColumn * column = arguments[0].column.get();
ColumnPtr res_column;
WhichDataType which(column->getDataType());
if (which.isAggregateFunction())
{
auto to_string = FunctionFactory::instance().get("toString", context);
const ColumnPtr col = to_string->build(arguments)->execute(arguments, result_type, input_rows_count);
const auto * name_col = checkAndGetColumn<ColumnString>(col.get());
tryExecuteString(name_col, res_column);
return res_column;
}
if (tryExecuteUInt<UInt8>(column, res_column) ||
tryExecuteUInt<UInt16>(column, res_column) ||
tryExecuteUInt<UInt32>(column, res_column) ||

4
tests/queries/0_stateless/01926_bin_unbin.reference
View File

@ -33,3 +33,7 @@
1
1
1
1
1
2D000000000000000A
001011010000000000000000000000000000000000000000000000000000000000001010

6
tests/queries/0_stateless/01926_bin_unbin.sql
View File

@ -37,3 +37,9 @@ select bin(unbin('0')) == '00000000';
select hex('') == bin('');
select unhex('') == unbin('');
select unhex('0') == unbin('0');
-- hex and bin support AggregateFunction
select hex(sumState(number)) == hex(toString(sumState(number))) from numbers(10);
select hex(avgState(number)) == hex(toString(avgState(number))) from numbers(99);
select hex(avgState(number)) from numbers(10);
select bin(avgState(number)) from numbers(10);