Incorporate review feedback

src/Access/AccessRights.cpp

@@ -258,6 +258,7 @@ namespace
             case TABLE_LEVEL: return AccessFlags::allFlagsGrantableOnTableLevel();
             case COLUMN_LEVEL: return AccessFlags::allFlagsGrantableOnColumnLevel();
         }
+        chassert(false);
     }
 }
 

src/AggregateFunctions/AggregateFunctionSum.h

@@ -457,12 +457,12 @@ public:
 
     String getName() const override
     {
-        switch (Type)
-        {
-            case AggregateFunctionTypeSum: return "sum";
-            case AggregateFunctionTypeSumWithOverflow: return "sumWithOverflow";
-            case AggregateFunctionTypeSumKahan: return "sumKahan";
-        }
+        if constexpr (Type == AggregateFunctionTypeSum)
+            return "sum";
+        else if constexpr (Type == AggregateFunctionTypeSumWithOverflow)
+            return "sumWithOverflow";
+        else if constexpr (Type == AggregateFunctionTypeSumKahan)
+            return "sumKahan";
     }
 
     explicit AggregateFunctionSum(const DataTypes & argument_types_)

src/Compression/CompressionCodecDoubleDelta.cpp

@@ -142,9 +142,9 @@ namespace ErrorCodes
 {
     extern const int CANNOT_COMPRESS;
     extern const int CANNOT_DECOMPRESS;
-    extern const int BAD_ARGUMENTS;
     extern const int ILLEGAL_SYNTAX_FOR_CODEC_TYPE;
     extern const int ILLEGAL_CODEC_PARAMETER;
+    extern const int LOGICAL_ERROR;
 }
 
 namespace
@@ -163,7 +163,7 @@ inline Int64 getMaxValueForByteSize(Int8 byte_size)
         case sizeof(UInt64):
             return std::numeric_limits<Int64>::max();
         default:
-            throw Exception(ErrorCodes::BAD_ARGUMENTS, "only 1, 2, 4 and 8 data sizes are supported");
+            throw Exception(ErrorCodes::LOGICAL_ERROR, "only 1, 2, 4 and 8 data sizes are supported");
     }
 }
 

src/Coordination/KeeperReconfiguration.cpp

@@ -8,7 +8,7 @@ namespace DB
 
 namespace ErrorCodes
 {
-    extern const int UNEXPECTED_ZOOKEEPER_ERROR;
+    extern const int LOGICAL_ERROR;
 }
 
 ClusterUpdateActions joiningToClusterUpdates(const ClusterConfigPtr & cfg, std::string_view joining)
@@ -85,7 +85,7 @@ String serializeClusterConfig(const ClusterConfigPtr & cfg, const ClusterUpdateA
             new_config.emplace_back(RaftServerConfig{*cfg->get_server(priority->id)});
         }
         else
-            throw Exception(ErrorCodes::UNEXPECTED_ZOOKEEPER_ERROR, "Unexpected update");
+            throw Exception(ErrorCodes::LOGICAL_ERROR, "Unexpected update");
     }
 
     for (const auto & item : cfg->get_servers())

src/Coordination/KeeperServer.cpp

@@ -991,7 +991,7 @@ KeeperServer::ConfigUpdateState KeeperServer::applyConfigUpdate(
         raft_instance->set_priority(update->id, update->priority, /*broadcast on live leader*/true);
         return Accepted;
     }
-    throw Exception(ErrorCodes::UNEXPECTED_ZOOKEEPER_ERROR, "Unexpected action");
+    chassert(false);
 }
 
 ClusterUpdateActions KeeperServer::getRaftConfigurationDiff(const Poco::Util::AbstractConfiguration & config)

src/Core/Field.cpp

@@ -146,6 +146,7 @@ inline Field getBinaryValue(UInt8 type, ReadBuffer & buf)
         case Field::Types::CustomType:
             return Field();
     }
+    UNREACHABLE();
 }
 
 void readBinary(Array & x, ReadBuffer & buf)

src/Functions/FunctionsTimeWindow.cpp

@@ -232,7 +232,6 @@ struct TimeWindowImpl<TUMBLE>
             default:
                 throw Exception(ErrorCodes::SYNTAX_ERROR, "Fraction seconds are unsupported by windows yet");
         }
-        UNREACHABLE();
     }
 
     template <typename ToType, IntervalKind::Kind unit>
@@ -422,7 +421,6 @@ struct TimeWindowImpl<HOP>
             default:
                 throw Exception(ErrorCodes::SYNTAX_ERROR, "Fraction seconds are unsupported by windows yet");
         }
-        UNREACHABLE();
     }
 
     template <typename ToType, IntervalKind::Kind kind>

src/Parsers/Lexer.cpp

@@ -41,6 +41,8 @@ Token quotedString(const char *& pos, const char * const token_begin, const char
             ++pos;
             continue;
         }
+
+        chassert(false);
     }
 }