thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

get rid of unique pointer

Browse Source 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
This commit is contained in:
Duc Canh Le 2023-09-20 09:31:03 +00:00
parent 5ace2a15db
commit e6a3f3ed01
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/Common/isLocalAddress.cpp
View File

@ -1,12 +1,14 @@
#include <Common/isLocalAddress.h>
#include <ifaddrs.h>
#include <chrono>
#include <cstring>
#include <memory>
#include <mutex>
#include <shared_mutex>
#include <optional>
#include <base/types.h>
#include <boost/core/noncopyable.hpp>
#include <Common/Exception.h>
#include <Poco/Net/IPAddress.h>
#include <Poco/Net/SocketAddress.h>
@ -23,7 +25,7 @@ namespace ErrorCodes
namespace
{
struct NetworkInterfaces
struct NetworkInterfaces : public boost::noncopyable
{
ifaddrs * ifaddr;
NetworkInterfaces()
@ -34,6 +36,12 @@ struct NetworkInterfaces
}
}
void swap(NetworkInterfaces && other)
{
ifaddr = other.ifaddr;
other.ifaddr = nullptr;
}
bool hasAddress(const Poco::Net::IPAddress & address) const
{
ifaddrs * iface;
@ -80,24 +88,24 @@ struct NetworkInterfaces
static const NetworkInterfaces & instance()
{
static constexpr int NET_INTERFACE_VALID_PERIOD_SECONDS = 30;
static std::unique_ptr<NetworkInterfaces> nf = std::make_unique<NetworkInterfaces>();
static time_t last_updated_time = time(nullptr);
static constexpr int NET_INTERFACE_VALID_PERIOD_MS = 30000;
static NetworkInterfaces nf;
static auto last_updated_time = std::chrono::steady_clock::now();
static std::shared_mutex nf_mtx;
time_t now = time(nullptr);
auto now = std::chrono::steady_clock::now();
if (now - last_updated_time > NET_INTERFACE_VALID_PERIOD_SECONDS)
if (std::chrono::duration_cast<std::chrono::milliseconds>(now - last_updated_time).count() > NET_INTERFACE_VALID_PERIOD_MS)
{
std::unique_lock lock(nf_mtx);
nf = std::make_unique<NetworkInterfaces>();
nf.swap(NetworkInterfaces());
last_updated_time = now;
return *nf;
return nf;
}
else
{
std::shared_lock lock(nf_mtx);
return *nf;
return nf;
}
}
};