mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-10-18 06:20:51 +00:00
Fix gcc build, fix PVS error
This commit is contained in:
Dmitrii Kovalkov
parent
bd847514ba
commit
ea1285328b
@ -103,7 +103,8 @@ void RandImpl2::execute(char * output, size_t size)
|
||||
unalignedStore<UInt32>(output + 28, generator7.next());
|
||||
}
|
||||
|
||||
if (end - output > 0) {
|
||||
if (end - output > 0)
|
||||
{
|
||||
unalignedStore<UInt32>(output, generator0.next());
|
||||
unalignedStore<UInt32>(output + 4, generator1.next());
|
||||
unalignedStore<UInt32>(output + 8, generator2.next());
|
||||
|
||||
@ -2,64 +2,65 @@
|
||||
|
||||
#include <Core/Types.h>
|
||||
|
||||
/// This file contains macros and helpers for writing platform-dependent code.
|
||||
///
|
||||
/// Macros DECLARE_<Arch>_SPECIFIC_CODE will wrap code inside them into the
|
||||
/// namespace TargetSpecific::<Arch> and enable Arch-specific compile options.
|
||||
/// Thus, it's allowed to call functions inside these namespaces only after
|
||||
/// checking platform in runtime (see IsArchSupported() below).
|
||||
///
|
||||
/// For similarities there is a macros DECLARE_DEFAULT_CODE, which wraps code
|
||||
/// into the namespace TargetSpecific::Default but dosn't specify any additional
|
||||
/// copile options.
|
||||
///
|
||||
/// Example:
|
||||
///
|
||||
/// DECLARE_DEFAULT_CODE (
|
||||
/// int funcImpl() {
|
||||
/// return 1;
|
||||
/// }
|
||||
/// ) // DECLARE_DEFAULT_CODE
|
||||
///
|
||||
/// DECLARE_AVX2_SPECIFIC_CODE (
|
||||
/// int funcImpl() {
|
||||
/// return 2;
|
||||
/// }
|
||||
/// ) // DECLARE_DEFAULT_CODE
|
||||
///
|
||||
/// int func() {
|
||||
/// if (IsArchSupported(TargetArch::AVX2))
|
||||
/// return TargetSpecifc::AVX2::funcImpl();
|
||||
/// return TargetSpecifc::Default::funcImpl();
|
||||
/// }
|
||||
///
|
||||
/// Sometimes code may benefit from compiling with different options.
|
||||
/// For these purposes use DECLARE_MULTITARGET_CODE macros. It will create several
|
||||
/// copies of the code and compile it with different options. These copies are
|
||||
/// available via TargetSpecifc namespaces described above.
|
||||
///
|
||||
/// Inside every TargetSpecific namespace there is a constexpr variable BuildArch,
|
||||
/// which indicates the target platform for current code.
|
||||
///
|
||||
/// Example:
|
||||
///
|
||||
/// DECLARE_MULTITARGET_CODE(
|
||||
/// int funcImpl(int size, ...) {
|
||||
/// int iteration_size = 1;
|
||||
/// if constexpr (BuildArch == TargetArch::SSE42)
|
||||
/// iteration_size = 2
|
||||
/// else if constexpr (BuildArch == TargetArch::AVX || BuildArch == TargetArch::AVX2)
|
||||
/// iteration_size = 4;
|
||||
/// else if constexpr (BuildArch == TargetArch::AVX512)
|
||||
/// iteration_size = 8;
|
||||
/// for (int i = 0; i < size; i += iteration_size)
|
||||
/// ...
|
||||
/// }
|
||||
/// ) // DECLARE_MULTITARGET_CODE
|
||||
///
|
||||
/// // All 5 versions of func are available here. Use runtime detection to choose one.
|
||||
///
|
||||
/// If you want to write IFunction or IExecutableFuncionImpl with runtime dispatching, see PerformanceAdaptors.h.
|
||||
/* This file contains macros and helpers for writing platform-dependent code.
|
||||
*
|
||||
* Macros DECLARE_<Arch>_SPECIFIC_CODE will wrap code inside them into the
|
||||
* namespace TargetSpecific::<Arch> and enable Arch-specific compile options.
|
||||
* Thus, it's allowed to call functions inside these namespaces only after
|
||||
* checking platform in runtime (see IsArchSupported() below).
|
||||
*
|
||||
* For similarities there is a macros DECLARE_DEFAULT_CODE, which wraps code
|
||||
* into the namespace TargetSpecific::Default but dosn't specify any additional
|
||||
* copile options.
|
||||
*
|
||||
* Example:
|
||||
*
|
||||
* DECLARE_DEFAULT_CODE (
|
||||
* int funcImpl() {
|
||||
* return 1;
|
||||
* }
|
||||
* ) // DECLARE_DEFAULT_CODE
|
||||
*
|
||||
* DECLARE_AVX2_SPECIFIC_CODE (
|
||||
* int funcImpl() {
|
||||
* return 2;
|
||||
* }
|
||||
* ) // DECLARE_DEFAULT_CODE
|
||||
*
|
||||
* int func() {
|
||||
* if (IsArchSupported(TargetArch::AVX2))
|
||||
* return TargetSpecifc::AVX2::funcImpl();
|
||||
* return TargetSpecifc::Default::funcImpl();
|
||||
* }
|
||||
*
|
||||
* Sometimes code may benefit from compiling with different options.
|
||||
* For these purposes use DECLARE_MULTITARGET_CODE macros. It will create several
|
||||
* copies of the code and compile it with different options. These copies are
|
||||
* available via TargetSpecifc namespaces described above.
|
||||
*
|
||||
* Inside every TargetSpecific namespace there is a constexpr variable BuildArch,
|
||||
* which indicates the target platform for current code.
|
||||
*
|
||||
* Example:
|
||||
*
|
||||
* DECLARE_MULTITARGET_CODE(
|
||||
* int funcImpl(int size, ...) {
|
||||
* int iteration_size = 1;
|
||||
* if constexpr (BuildArch == TargetArch::SSE42)
|
||||
* iteration_size = 2
|
||||
* else if constexpr (BuildArch == TargetArch::AVX || BuildArch == TargetArch::AVX2)
|
||||
* iteration_size = 4;
|
||||
* else if constexpr (BuildArch == TargetArch::AVX512)
|
||||
* iteration_size = 8;
|
||||
* for (int i = 0; i < size; i += iteration_size)
|
||||
* ...
|
||||
* }
|
||||
* ) // DECLARE_MULTITARGET_CODE
|
||||
*
|
||||
* // All 5 versions of func are available here. Use runtime detection to choose one.
|
||||
*
|
||||
* If you want to write IFunction or IExecutableFuncionImpl with runtime dispatching, see PerformanceAdaptors.h.
|
||||
*/
|
||||
|
||||
namespace DB
|
||||
{
|
||||
@ -83,15 +84,21 @@ String ToString(TargetArch arch);
|
||||
constexpr bool UseMultitargetCode = true;
|
||||
|
||||
#if defined(__clang__)
|
||||
# define BEGIN_AVX512F_SPECIFIC_CODE _Pragma(\
|
||||
"clang attribute push (__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx,avx2,avx512f\"))),apply_to=function)")
|
||||
# define BEGIN_AVX2_SPECIFIC_CODE _Pragma(\
|
||||
"clang attribute push (__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx,avx2\"))),apply_to=function)")
|
||||
# define BEGIN_AVX_SPECIFIC_CODE _Pragma(\
|
||||
"clang attribute push (__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx\"))),apply_to=function)")
|
||||
# define BEGIN_SSE42_SPECIFIC_CODE _Pragma(\
|
||||
"clang attribute push (__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx\"))),apply_to=function)")
|
||||
# define END_TARGET_SPECIFIC_CODE _Pragma("clang attribute pop")
|
||||
# define BEGIN_AVX512F_SPECIFIC_CODE \
|
||||
_Pragma("clang attribute push(__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx,avx2,avx512f\"))),apply_to=function)")
|
||||
# define BEGIN_AVX2_SPECIFIC_CODE \
|
||||
_Pragma("clang attribute push(__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx,avx2\"))),apply_to=function)")
|
||||
# define BEGIN_AVX_SPECIFIC_CODE \
|
||||
_Pragma("clang attribute push(__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx,avx\"))),apply_to=function)")
|
||||
# define BEGIN_SSE42_SPECIFIC_CODE \
|
||||
_Pragma("clang attribute push(__attribute__((target(\"sse,sse2,sse3,ssse3,sse4,popcnt,mmx\"))),apply_to=function)")
|
||||
# define END_TARGET_SPECIFIC_CODE \
|
||||
_Pragma("clang attribute pop")
|
||||
|
||||
/* Clang shows warning when there aren't any objects to apply pragma.
|
||||
* To prevent this warning we define this function inside every macros with pragmas.
|
||||
*/
|
||||
# define DUMMY_FUNCTION_DEFINITION void __dummy_function_definition();
|
||||
#else
|
||||
# define BEGIN_AVX512F_SPECIFIC_CODE \
|
||||
_Pragma("GCC push_options") \
|
||||
@ -107,12 +114,16 @@ constexpr bool UseMultitargetCode = true;
|
||||
_Pragma("GCC target(\"sse,sse2,sse3,ssse3,sse4,popcnt,abm,mmx,tune=native\")")
|
||||
# define END_TARGET_SPECIFIC_CODE \
|
||||
_Pragma("GCC pop_options")
|
||||
|
||||
/* GCC doesn't show such warning, we don't need to define anything.
|
||||
*/
|
||||
# define DUMMY_FUNCTION_DEFINITION
|
||||
#endif
|
||||
|
||||
#define DECLARE_SSE42_SPECIFIC_CODE(...) \
|
||||
BEGIN_SSE42_SPECIFIC_CODE \
|
||||
namespace TargetSpecific::SSE42 { \
|
||||
void __dummy_function_clang(); \
|
||||
DUMMY_FUNCTION_DEFINITION \
|
||||
using namespace DB::TargetSpecific::SSE42; \
|
||||
__VA_ARGS__ \
|
||||
} \
|
||||
@ -121,7 +132,7 @@ END_TARGET_SPECIFIC_CODE
|
||||
#define DECLARE_AVX_SPECIFIC_CODE(...) \
|
||||
BEGIN_AVX_SPECIFIC_CODE \
|
||||
namespace TargetSpecific::AVX { \
|
||||
void __dummy_function_clang(); \
|
||||
DUMMY_FUNCTION_DEFINITION \
|
||||
using namespace DB::TargetSpecific::AVX; \
|
||||
__VA_ARGS__ \
|
||||
} \
|
||||
@ -130,7 +141,7 @@ END_TARGET_SPECIFIC_CODE
|
||||
#define DECLARE_AVX2_SPECIFIC_CODE(...) \
|
||||
BEGIN_AVX2_SPECIFIC_CODE \
|
||||
namespace TargetSpecific::AVX2 { \
|
||||
void __dummy_function_clang(); \
|
||||
DUMMY_FUNCTION_DEFINITION \
|
||||
using namespace DB::TargetSpecific::AVX2; \
|
||||
__VA_ARGS__ \
|
||||
} \
|
||||
@ -139,7 +150,7 @@ END_TARGET_SPECIFIC_CODE
|
||||
#define DECLARE_AVX512F_SPECIFIC_CODE(...) \
|
||||
BEGIN_AVX512F_SPECIFIC_CODE \
|
||||
namespace TargetSpecific::AVX512F { \
|
||||
void __dummy_function_clang(); \
|
||||
DUMMY_FUNCTION_DEFINITION \
|
||||
using namespace DB::TargetSpecific::AVX512F; \
|
||||
__VA_ARGS__ \
|
||||
} \
|
||||
|
||||
Loading…
Reference in New Issue
Block a user