Retry to resolve the table identifier

src/Analyzer/Resolve/IdentifierResolver.cpp

@@ -412,27 +412,41 @@ QueryTreeNodePtr IdentifierResolver::tryResolveTableIdentifierFromDatabaseCatalo
         table_name = table_identifier[0];
     }
 
-    StorageID storage_id(database_name, table_name);
-    storage_id = context->resolveStorageID(storage_id);
-    bool is_temporary_table = storage_id.getDatabaseName() == DatabaseCatalog::TEMPORARY_DATABASE;
+    const int max_retry = 5;
+    for (int i = 0; i < max_retry; ++i)
+    {
+        StorageID storage_id(database_name, table_name);
+        storage_id = context->resolveStorageID(storage_id);
+        bool is_temporary_table = storage_id.getDatabaseName() == DatabaseCatalog::TEMPORARY_DATABASE;
 
-    StoragePtr storage;
+        StoragePtr storage;
 
-    if (is_temporary_table)
-        storage = DatabaseCatalog::instance().getTable(storage_id, context);
-    else
-        storage = DatabaseCatalog::instance().tryGetTable(storage_id, context);
+        if (is_temporary_table)
+            storage = DatabaseCatalog::instance().getTable(storage_id, context);
+        else
+            storage = DatabaseCatalog::instance().tryGetTable(storage_id, context);
 
-    if (!storage)
-        return {};
+        if (!storage)
+            return {};
 
-    auto storage_lock = storage->lockForShare(context->getInitialQueryId(), context->getSettingsRef()[Setting::lock_acquire_timeout]);
-    auto storage_snapshot = storage->getStorageSnapshot(storage->getInMemoryMetadataPtr(), context);
-    auto result = std::make_shared<TableNode>(std::move(storage), std::move(storage_lock), std::move(storage_snapshot));
-    if (is_temporary_table)
-        result->setTemporaryTableName(table_name);
+        auto storage_lock
+            = storage->tryLockForShare(context->getInitialQueryId(), context->getSettingsRef()[Setting::lock_acquire_timeout]);
+        /// If storage is dropped or detached, it is unable to get the lock. We retry with the new table if exists.
+        if (!storage_lock)
+            continue;
 
-    return result;
+        auto storage_snapshot = storage->getStorageSnapshot(storage->getInMemoryMetadataPtr(), context);
+        auto result = std::make_shared<TableNode>(std::move(storage), std::move(storage_lock), std::move(storage_snapshot));
+        if (is_temporary_table)
+            result->setTemporaryTableName(table_name);
+
+        return result;
+    }
+
+    throw Exception(
+        ErrorCodes::INVALID_IDENTIFIER,
+        "Unable to resolve table identifier: {}, the table is dropped or detached",
+        table_identifier.getFullName());
 }
 
 /// Resolve identifier from compound expression

tests/queries/0_stateless/03237_create-or-replace-view-atomically-with-atomic-engine.sh

@@ -1,47 +0,0 @@
-#!/usr/bin/env bash
-
-CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-# shellcheck source=../shell_config.sh
-. "$CUR_DIR"/../shell_config.sh
-
-# with Atomic engine
-$CLICKHOUSE_CLIENT --query "DROP DATABASE IF EXISTS ${CLICKHOUSE_DATABASE}_db"
-$CLICKHOUSE_CLIENT --query "CREATE DATABASE ${CLICKHOUSE_DATABASE}_db ENGINE=Atomic"
-
-function create_or_replace_view_thread
-{
-    for _ in {1..50}; do
-        $CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'"
-    done
-}
-export -f create_or_replace_view_thread;
-
-function select_view_thread
-{
-    for _ in {1..50}; do
-        $CLICKHOUSE_CLIENT --query "SELECT * FROM ${CLICKHOUSE_DATABASE}_db.test_view" | grep -v "abcdef"
-    done
-}
-export -f select_view_thread;
-
-$CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'"
-
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-bash -c create_or_replace_view_thread &
-
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-bash -c select_view_thread &
-
-wait

tests/queries/0_stateless/03237_create_or_replace_view_atomically_with_atomic_engine.sh

@@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+
+CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CUR_DIR"/../shell_config.sh
+
+# with Atomic engine
+$CLICKHOUSE_CLIENT --query "DROP DATABASE IF EXISTS ${CLICKHOUSE_DATABASE}_db"
+$CLICKHOUSE_CLIENT --query "CREATE DATABASE ${CLICKHOUSE_DATABASE}_db ENGINE=Atomic"
+
+function create_or_replace_view_thread
+{
+    for _ in {1..10}; do
+        $CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'" > /dev/null
+    done
+}
+export -f create_or_replace_view_thread;
+
+function select_view_thread
+{
+    for _ in {1..10}; do
+        $CLICKHOUSE_CLIENT --query "SELECT * FROM ${CLICKHOUSE_DATABASE}_db.test_view" > /dev/null
+    done
+}
+export -f select_view_thread;
+
+$CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'" > /dev/null
+{
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+    bash -c select_view_thread &
+
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+    bash -c create_or_replace_view_thread &
+} > >(cat) 2> >(cat >&2)
+
+for _ in {1..100}; do
+    $CLICKHOUSE_CLIENT --query "SELECT * FROM ${CLICKHOUSE_DATABASE}_db.test_view" | grep -v abcdef
+done
+
+wait

tests/queries/0_stateless/03238_create_or_replace_view_atomically_with_replicated_engine.sh

@@ -10,21 +10,21 @@ $CLICKHOUSE_CLIENT --query "CREATE DATABASE ${CLICKHOUSE_DATABASE}_db ENGINE=Rep
 
 function create_or_replace_view_thread
 {
-    for _ in {1..50}; do
-        $CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'"
+    for _ in {1..10}; do
+        $CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'" > /dev/null
     done
 }
 export -f create_or_replace_view_thread;
 
 function select_view_thread
 {
-    for _ in {1..50}; do
-        $CLICKHOUSE_CLIENT --query "SELECT * FROM ${CLICKHOUSE_DATABASE}_db.test_view" | grep -v "abcdef"
+    for _ in {1..10}; do
+        $CLICKHOUSE_CLIENT --query "SELECT * FROM ${CLICKHOUSE_DATABASE}_db.test_view" > /dev/null
     done
 }
 export -f select_view_thread;
 
-$CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'"
+$CLICKHOUSE_CLIENT --query "CREATE OR REPLACE VIEW ${CLICKHOUSE_DATABASE}_db.test_view AS SELECT 'abcdef'" > /dev/null
 
 bash -c create_or_replace_view_thread &
 bash -c create_or_replace_view_thread &