thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 01:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Another attempt.

Browse Source
This commit is contained in:
Nikolai Kochetov 2024-03-22 10:51:01 +00:00
parent 89d80a4d65
commit ec134d2642
1 changed files with 2 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/Analyzer/Passes/QueryAnalysisPass.cpp
View File

@ -802,7 +802,7 @@ struct IdentifierResolveScope
struct ResolvedFunctionsCache struct ResolvedFunctionsCache
{ {
FunctionOverloadResolverPtr resolver; FunctionOverloadResolverPtr resolver;
std::map<IQueryTreeNode::Hash, FunctionBasePtr> cache; FunctionBasePtr function_base;
}; };
std::map<IQueryTreeNode::Hash, ResolvedFunctionsCache> functions_cache; std::map<IQueryTreeNode::Hash, ResolvedFunctionsCache> functions_cache;
@ -931,24 +931,6 @@ struct IdentifierResolveScope
} }
}; };
IQueryTreeNode::Hash getHashForFunctionArguments(const ColumnsWithTypeAndName & arguments)
{
SipHash hash;
for (const auto & arg : arguments)
{
auto type_name = arg.type->getName();
hash.update(type_name.c_str(), type_name.size());
if (arg.column)
{
if (const auto * col_const = typeid_cast<const ColumnConst *>(arg.column.get()))
col_const->updateHashWithValue(0, hash);
}
}
return getSipHash128AsPair(hash);
}
/** Visitor that extracts expression and function aliases from node and initialize scope tables with it. /** Visitor that extracts expression and function aliases from node and initialize scope tables with it.
* Does not go into child lambdas and queries. * Does not go into child lambdas and queries.
@ -5798,8 +5780,7 @@ ProjectionNames QueryAnalyzer::resolveFunction(QueryTreeNodePtr & node, Identifi
FunctionBasePtr function_base; FunctionBasePtr function_base;
if (function_cache) if (function_cache)
{ {
auto args_hash = getHashForFunctionArguments(argument_columns); auto & cached_function = function_cache->function_base;
auto & cached_function = function_cache->cache[args_hash];
if (!cached_function) if (!cached_function)
cached_function = function->build(argument_columns); cached_function = function->build(argument_columns);